Skip to content

Fix 378 and 380#381

Merged
alphaville merged 31 commits intomasterfrom
fix/380-pkg-resources
Mar 13, 2026
Merged

Fix 378 and 380#381
alphaville merged 31 commits intomasterfrom
fix/380-pkg-resources

Conversation

@alphaville
Copy link
Owner

@alphaville alphaville commented Mar 9, 2026 •
edited
Loading

Both issues #378 and #380 have been addressed. The dependency modcholesky has been removed; instead, the struct CholeskyFactoriser is introduced, where we compute the Cholesky factorisation ourselves.

Main Changes

  • Rewrite definitions.py without using pkg_resources
  • Implement custom Cholesky factorizer (see CholeskyFactoriser)
  • Implement function matrix_operations::mul_a_at, which compute $AA^\intercal$ (using ndarray)
  • In the test test_raspberry_pi.py, the local version of OpEn is used (same as in all other tests)
  • AffineSpace reimplemented using CholeskyFactoriser; all tests pass

Associated Issues

Checklist

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)
  • Clippy recommendations addressed

dependabot bot and others added 3 commits November 17, 2025 19:03
@dependabot
Update lbfgs requirement from 0.2 to 0.3
bf7f875 
Updates the requirements on [lbfgs](https://github.com/korken89/lbfgs-rs) to permit the latest version.
- [Release notes](https://github.com/korken89/lbfgs-rs/releases)
- [Changelog](https://github.com/korken89/lbfgs-rs/blob/master/CHANGELOG.md)
- [Commits](korken89/lbfgs-rs@v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: lbfgs
  dependency-version: 0.3.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Update rand requirement from 0.9 to 0.10
58727b2 
Updates the requirements on [rand](https://github.com/rust-random/rand) to permit the latest version.
- [Release notes](https://github.com/rust-random/rand/releases)
- [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md)
- [Commits](rust-random/rand@rand_core-0.9.1...0.10.0)

---
updated-dependencies:
- dependency-name: rand
  dependency-version: 0.10.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@alphaville
rewrite definitions without pkg_resources
7feebc6
@alphaville alphaville self-assigned this Mar 9, 2026
@alphaville alphaville changed the title Rewrite definitions.py without pkg_resources Fix 378 and 380 Mar 9, 2026
@alphaville alphaville marked this pull request as draft March 9, 2026 23:40
@alphaville alphaville added bug Something isn't working python issue related to python rust issue related to the code Rust library appveyor Appveyor continuous integration codegen Code generation labels Mar 10, 2026
@alphaville alphaville marked this pull request as ready for review March 10, 2026 15:04
@alphaville
mild refactoring
353414c 
About:
- clippy recomendations
- rename variables for readability
@alphaville alphaville mentioned this pull request Mar 10, 2026
Closed
@alphaville alphaville requested a review from korken89 March 10, 2026 16:01
alphaville and others added 12 commits March 10, 2026 20:22
@alphaville
clippy fixes and docs
81f7c5b
@alphaville
Merge pull request #377 from alphaville/dependabot/cargo/rand-0.10
3d563d4 
Update rand requirement from 0.9 to 0.10
@alphaville
Merge pull request #375 from alphaville/dependabot/cargo/lbfgs-0.3
5f7beb3 
Update lbfgs requirement from 0.2 to 0.3
@dependabot
Update icasadi_test requirement from 0.0.2 to 0.0.3
cfae0a1 
Updates the requirements on icasadi_test to permit the latest version.

---
updated-dependencies:
- dependency-name: icasadi_test
  dependency-version: 0.0.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@alphaville
Merge pull request #371 from alphaville/dependabot/cargo/icasadi_test…
7325d57 
…-0.0.3

Update icasadi_test requirement from 0.0.2 to 0.0.3
@alphaville
self.is_factorized safety (in CholeskyFactorizer)
2124049
@alphaville
[ci skip] fix clippy warnings
f8e4c68 
About:
- clippy warnings associated with docs
@alphaville
bump unit_test_utils version to 0.1.4
6eb43a9
@alphaville
Safer templates_dir implementation
6f48dd7 
About:
- Removed as_file(resource)
- Returning resource directly
@alphaville
CholeskyFactorizer: better testing
b4a209d 
About:
- Unit test to cover cases where the user attempts to solve without first factorizing
- and where the factorization has failed (e.g., not pos. def. matrix)
@alphaville
Run cargo-fmt to format Rust code
876616e
@alphaville
Merge pull request #382 from alphaville/hotfix/templates_dir
61abed5 
Safer templates_dir implementation
@alphaville
Copy link
Owner Author

alphaville commented Mar 11, 2026

@korken89 after some recent changes to the Rust compiler, one of our dependencies, modcholesky, stopped working (see #378). This PR fixes this issue and another similar issue in Python (#380). I implemented the Cholesky factorization myself; see src/cholesky_factorizer.rs. Will you be able to give this a review? I'd like to release a new version asap because currently the users cannot use OpE due to these bugs.

This was referenced Mar 11, 2026
Open
Draft
@alphaville alphaville merged commit 1013871 into master Mar 13, 2026
9 checks passed
@alphaville alphaville deleted the fix/380-pkg-resources branch March 13, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@korken89 korken89 Awaiting requested review from korken89

Assignees

@alphaville alphaville

Labels

appveyor Appveyor continuous integration bug Something isn't working codegen Code generation python issue related to python rust issue related to the code Rust library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module pkg_resources not found Build fails due to modcholesky dependency under rustc versions >= 1.94.0

1 participant

@alphaville