Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Selector #751

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Megarushing
Copy link

@Megarushing Megarushing commented Apr 26, 2021

This PR adds a small View after login that shows up only when the user belongs to more than 1 team,

This view allows them to choose which team to use AltStore with.

I needed this change in order to be able to use my organization profile, which yields 1 year expiry dates. The auto-selection process was prioritizing the free account. Hope this also helps more people

I have pushed an IPA file as a release in my forked version so ppl may test and use it while we go through the merge process: https://github.com/Megarushing/AltStore/releases/download/1.4.5t/AltStore.ipa

This can be sideloaded with AltStore itself and will not interfere with the existing app as it is a different package name
EDIT: Before sideloading it you will need to set the ALTDeviceID to your own Device UUID inside the Info.plist file contained in the IPA

https://github.com/Megarushing/AltStore/releases/tag/1.4.5t

Team selector

Note: when merging please discard the package, app group and team changes as those were needed in order to be able to compile and run in my environment

@rbutera
Copy link

rbutera commented Jun 12, 2021

@rileytestut can we get this merged?

@3935849xx
Copy link

3935849xx commented Jun 13, 2021 via email

@rbutera
Copy link

rbutera commented Jun 24, 2021

@rileytestut this PR has been ready for review and merge for 58 days now - what's the hold up?

@lonkelle
Copy link
Member

Okay, guys, @rileytestut's original plan was to allow multiple team switching in AltServer, and AltStore. But things got tricky, the only way to not confuse users and allow switching teams on-device we have to complete three Trello cards here: https://trello.com/c/DyZLydN3/18-feature-select-team-when-an-apple-id-has-one-or-multiple-organizations (btw, this PR is linked there as a reference for the UI work @Megarushing did as this should be a possibility one day when the other cards get taken care of).

The current plan we now have which is to exclusively allow choosing a team on initial install of AltStore with AltServer and that's currently in development, here's the card for that: https://trello.com/c/DyZLydN3/18-feature-select-team-when-an-apple-id-has-one-or-multiple-organizations

@mengunogul
Copy link

I changed ALTDeviceID and ALTServerID. There is no connection problem but when I try to renew I am facing this issue. Any ideas why?

IMG_0329

@CobreDev
Copy link

CobreDev commented Nov 9, 2021

Any chance you could update this with AltStore v1.4.8? As hard as I try, I can't seem to figure out how to compile it myself.

@cmersinli
Copy link

Any chance you could update this with AltStore v1.4.8? As hard as I try, I can't seem to figure out how to compile it myself.

+1

@drpoutine
Copy link

+1 for this. Can't test with latest develop branch due to depends not being pushed

@cmersinli
Copy link

+1 for this. Can't test with latest develop branch due to depends not being pushed
I m using https://sideloadly.io now .

@lonkelle
Copy link
Member

lonkelle commented Feb 3, 2022

+1 for this. Can't test with latest develop branch due to depends not being pushed

^^^
@rileytestut Are you missing pushing some local stuff upstream?

@iMonZ
Copy link

iMonZ commented Feb 13, 2022

Great work thank you so much!
Any new on that?

Is it possible to merge develop into this branch, so we could compile the .ipa ourselves?

@Megarushing
Copy link
Author

When we see a good open source project the community can’t help it but want to collaborate on it, when we see this kind of thing being pulled after so long, this screams to the community NOT to try and collaborate any longer.

@lonkelle
Copy link
Member

lonkelle commented Dec 25, 2022

@Megarushing I feel the same as you, which is why I and a group of others made SideStore - to allow the community to have a real say in the future of alternative App Stores. Your PR for AltStore here has been merged into SideStore and has many other improvements: SideStore#9

When attempting to coax Riley into merging this PR in 2021, there was significant pushback due to it being against the "vision of the implementation" Riley had for AltStore. Long story, but it's why SideStore exists now. If you ever have any further passions you want implemented, we (the SideStore Team) accept, and act on, all PRs submitted.

PS. Not only did we merge your team selector, SideStore itself also doesn't need a connection to AltServer to function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants