Build/create release action #133
Conversation
… to gh-pages branch and attach it to the release
.github/workflows/release.yaml
Outdated
| const assets = latestRelease.data.assets.map(asset => asset.name); | ||
| let version = latestRelease.data.tag_name.replace(/^v/i, ''); | ||
| let release = 1 | ||
| if (assets.length === 0) { |
There was a problem hiding this comment.
❓"==" 🤣🤮
♻️
❓"===" 🤮🤣
🤙
.github/workflows/release.yaml
Outdated
| for (const asset of assets.data) { | ||
| await github.rest.repos.deleteReleaseAsset({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| asset_id: asset.id | ||
| }); | ||
| } |
There was a problem hiding this comment.
Are we sure that we want to delete every asset?
There was a problem hiding this comment.
Else, we can keep keep unwanted and old artifacts. Do you want me to change ?
There was a problem hiding this comment.
That's not what I meant. But we should replace the .rpm and .deb artifacts but not the others
There was a problem hiding this comment.
we should also replace container images. With this method, tar.gz and zip artifact are not deleted. Do you have an example of artifact we should keep ?
AngeCyp
force-pushed
the
build/create-release-action
branch
from
17f55d6 to
49d3561
Compare
There was a problem hiding this comment.
Added few comments
I believe the steps would be clearer if there were more context regarding the state of the release (whether it’s creating or updating). This would make the workflow easier to follow. It might help to include suffixes like ‘(Create case)’ and ‘(Update case)’ in the step titles, to clearly indicate which state each step is related to.
AngeCyp
force-pushed
the
build/create-release-action
branch
from
49d3561 to
3814ed2
Compare
AngeCyp
force-pushed
the
build/create-release-action
branch
from
3814ed2 to
02ef184
Compare
AngeCyp
force-pushed
the
build/create-release-action
branch
from
02ef184 to
52f7113
Compare
.github/workflows/release.yaml
Outdated
| needs: gather-informations | ||
| uses: alumet-dev/packaging/.github/workflows/build_rpm.yaml@main | ||
| with: | ||
| target-architecture: x86_64 |
.github/workflows/release.yaml
Outdated
| uses: alumet-dev/packaging/.github/workflows/build_rpm.yaml@main | ||
| with: | ||
| target-architecture: x86_64 | ||
| build-version: ${{ needs.gather-informations.outputs.version }} |
.github/workflows/release.yaml
Outdated
| repo: context.repo.repo, | ||
| asset_id: asset.id | ||
| }); | ||
| } catch (error) { |
There was a problem hiding this comment.
it fails see error here https://github.com/ahuret/alumet/actions/runs/14039822895/job/39307258080#step:5:51
AngeCyp
force-pushed
the
build/create-release-action
branch
from
52f7113 to
e59644c
Compare
|
Can you build Deb packages too? |
This PR add code for Github action to create all necessary artifacts and attach them to a release.
Close: #115