Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BlackBerry support #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added BlackBerry support #8

wants to merge 6 commits into from

Conversation

filmaj
Copy link

@filmaj filmaj commented Jun 26, 2012

What does this mean?

  • added dependencies to node-native-zip and adm-zip. One for creating archives, and one for extracting. Hurray!
  • due to the spec, target-dir attributes on source files in Java in BlackBerry will always be prefixed with "www/ext" - as that is always the location of the cordova.jar file. I think BlackBerry support is just another use case to programmatically read the package name from Java files, and thus eliminate the need for this attribute.

I think that's it.

@filmaj
Copy link
Author

filmaj commented Jun 27, 2012

Woops totally glossed over tests. Will add that for tomorrow!

@alunny
Copy link
Owner

alunny commented Jun 28, 2012

Cool, thanks Fil

@filmaj
Copy link
Author

filmaj commented Jun 28, 2012

Noticed that some existing tests are failing. Looks like the XML parser library used in the tests can't handle custom namespaced attributes. Fail :(

I'll dig around and see if there's another one that does, and perhaps add that as a test-only dependency?

@alunny
Copy link
Owner

alunny commented Jun 28, 2012

Tests are failing on master? Not seeing that here

@filmaj
Copy link
Author

filmaj commented Jul 10, 2012

Dude: sorry about lack of movement on this. 2.0 is fast approaching. This will need to get in for sure. Will get this done ASAP!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

7 similar comments
@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

@alunny I've added tests and rebased as of this morning. Should be good!

@filmaj
Copy link
Author

filmaj commented Jul 11, 2012

hmm. looks like my comment button worked. :o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants