-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BlackBerry support #8
base: master
Are you sure you want to change the base?
Conversation
Woops totally glossed over tests. Will add that for tomorrow! |
Cool, thanks Fil |
Noticed that some existing tests are failing. Looks like the XML parser library used in the tests can't handle custom namespaced attributes. Fail :( I'll dig around and see if there's another one that does, and perhaps add that as a test-only dependency? |
Tests are failing on master? Not seeing that here |
Dude: sorry about lack of movement on this. 2.0 is fast approaching. This will need to get in for sure. Will get this done ASAP! |
… ios were clashing), updated gitignore for this
@alunny I've added tests and rebased as of this morning. Should be good! |
7 similar comments
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
@alunny I've added tests and rebased as of this morning. Should be good! |
hmm. looks like my comment button worked. :o |
What does this mean?
target-dir
attributes on source files in Java in BlackBerry will always be prefixed with "www/ext" - as that is always the location of the cordova.jar file. I think BlackBerry support is just another use case to programmatically read the package name from Java files, and thus eliminate the need for this attribute.I think that's it.