Skip to content

Add CI pipeline#1

Merged
n-hallberg merged 4 commits into
mainfrom
ci-pipeline
Mar 2, 2026
Merged

Add CI pipeline#1
n-hallberg merged 4 commits into
mainfrom
ci-pipeline

Conversation

@n-hallberg
Copy link
Copy Markdown
Contributor

@n-hallberg n-hallberg commented Mar 2, 2026

  • Introduced .prettierrc and .prettierignore for code formatting.
  • Added cspell.json for spell checking configuration.
  • Created eslint.config.mjs for linting rules.
  • Set up GitHub Actions CI workflow for automated checks (linting, type checking, testing).
  • Added minimal fixture for E2E testing with Convex.
  • Included various utility scripts and configurations for testing and development.

Greptile Summary

This PR establishes a comprehensive CI/CD infrastructure for the convex-e2e testing library. It introduces automated quality checks (linting, type checking, formatting, spell checking) and a complete unit test suite achieving good coverage of the existing codebase. The E2E fixture provides a working example demonstrating how to use the library with a minimal Convex backend.

Key additions:

  • GitHub Actions workflow with two jobs: ci (quality checks and unit tests) and e2e (integration testing with fixtures)
  • Configuration files for ESLint, Prettier, and cspell with sensible defaults
  • Comprehensive unit tests for assertions, client, runner, reporter, and convex-run modules
  • Minimal E2E fixture with Convex backend, test suites, and helper functions
  • Exported previously internal functions (parseConvexOutput, filterSuites, parseError) to enable testing

Minor issue:

  • fixtures/minimal/convex/testSupport.ts:103 - table parameter is destructured but never used

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The PR adds infrastructure code (CI, tests, config files) without modifying core business logic. All changes are well-structured, follow best practices, and include comprehensive test coverage. The only issue is a minor unused parameter that doesn't affect functionality.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/ci.yml Adds comprehensive CI workflow with linting, type checking, spell checking, unit tests, and E2E tests
eslint.config.mjs Configures ESLint with TypeScript support, proper ignores, and reasonable rules
vitest.config.ts Simple Vitest configuration targeting tests directory
package.json Adds CI scripts (lint, type check, format, spell check, test) and required dev dependencies
tests/assertions.test.ts Comprehensive unit tests for all assertion helpers with edge cases
fixtures/minimal/e2e.config.ts E2E configuration defining roles, test functions, and suite loading
fixtures/minimal/convex/testSupport.ts Implements test support functions for auth, seeding, and data cleanup; includes unused table parameter in deleteTracked

Last reviewed commit: 8289d2e

- Introduced .prettierrc and .prettierignore for code formatting.
- Added cspell.json for spell checking configuration.
- Created eslint.config.mjs for linting rules.
- Set up GitHub Actions CI workflow for automated checks (linting, type checking, testing).
- Added minimal fixture for E2E testing with Convex.
- Included various utility scripts and configurations for testing and development.
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

27 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread fixtures/minimal/convex/testSupport.ts Outdated
- Added a new script for running end-to-end tests (`test:e2e`).
- Updated `createSession` function in `e2e.config.ts` to use `testAuth:createTestSession`.
- Refactored `run-e2e.sh` to correctly set the project root and execute the local backend script.
- Introduced new authentication configuration and HTTP handling in Convex.
- Removed obsolete session creation logic from `testSupport.ts` and added new test authentication functions.
@n-hallberg n-hallberg merged commit b40f7cd into main Mar 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant