Skip to content

Release flow#2

Merged
n-hallberg merged 2 commits into
mainfrom
release-flow
Mar 2, 2026
Merged

Release flow#2
n-hallberg merged 2 commits into
mainfrom
release-flow

Conversation

@n-hallberg
Copy link
Copy Markdown
Contributor

@n-hallberg n-hallberg commented Mar 2, 2026

Greptile Summary

Adds automated npm release workflow triggered by version tags, with branch verification and CI checks before publishing. Also updates package.json with standard repository URL format and public access configuration.

  • Critical issue: workflow is missing NODE_AUTH_TOKEN environment variable, causing authentication failure during npm publish
  • Tag verification step ensures releases only happen from main branch
  • package.json changes are correct and align with npm best practices

Confidence Score: 2/5

  • This PR cannot be merged as-is - the release workflow will fail authentication when attempting to publish
  • The workflow has a critical authentication issue that will prevent it from completing successfully. The missing NODE_AUTH_TOKEN environment variable means npm publish will fail. The package.json changes are fine, but the workflow is non-functional without the fix.
  • .github/workflows/release.yml requires immediate attention - add authentication token

Important Files Changed

Filename Overview
.github/workflows/release.yml new npm release workflow with tag verification and CI checks, but missing authentication token for publishing
package.json added standard git+ URL prefix and public access configuration for npm publishing

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push tag v*] --> B[Checkout code with full history]
    B --> C{Verify tag is on main branch}
    C -->|Not on main| D[Fail with error]
    C -->|On main| E[Setup pnpm & Node 22]
    E --> F[Install latest npm]
    F --> G[Install dependencies]
    G --> H[Run CI checks]
    H -->|Checks fail| I[Stop workflow]
    H -->|Checks pass| J[Publish to npm with provenance]
    J --> K[Release complete]
Loading

Last reviewed commit: 22d65b6

…iguration

- Changed repository URL format to use 'git+' prefix.
- Added 'publishConfig' section to specify public access for npm publishing.
- Added a step to check if the tag is on the main branch before proceeding with the release process.
- Set fetch-depth to 0 for the checkout action to ensure all history is available.
@n-hallberg n-hallberg merged commit 9c9effc into main Mar 2, 2026
3 checks passed
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +39 to +40
- name: Publish to npm
run: npm publish --provenance --access public
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing NODE_AUTH_TOKEN environment variable - npm publish will fail authentication

Suggested change
- name: Publish to npm
run: npm publish --provenance --access public
- name: Publish to npm
run: npm publish --provenance --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 39-40

Comment:
missing `NODE_AUTH_TOKEN` environment variable - npm publish will fail authentication

```suggestion
      - name: Publish to npm
        run: npm publish --provenance --access public
        env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
```

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant