fix: move utils module into mcp_acp package for PyPI distribution#38
Merged
jeremyeder merged 1 commit intoambient-code:mainfrom Mar 6, 2026
Merged
Conversation
The utils/pylogger module was at the repo root, outside the src/mcp_acp/ package. setuptools only includes mcp_acp* from src/, so the utils module was missing from the PyPI wheel, causing ImportError on install. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder
force-pushed
the
fix/packaging-utils-module
branch
from
c1055b6 to
1164b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/from repo root intosrc/mcp_acp/utils/so it gets included in the PyPI wheelserver.py,client.py,settings.pyfromfrom utils.pyloggertofrom mcp_acp.utils.pyloggerProblem
v0.2.2 on PyPI is broken —
pip install mcp-acp && mcp-acpcrashes with:The
utils/pylogger.pymodule lives at the repo root, outsidesrc/mcp_acp/. Sincepyproject.tomlonly includesmcp_acp*fromsrc/, theutilspackage is excluded from the built wheel. It only worked from the dev checkout becausesys.path.insertadded the repo root.Test plan
uv buildproduces wheel withmcp_acp/utils/__init__.pyandmcp_acp/utils/pylogger.pyuv tool installfrom built wheel succeedsmcp-acpstarts without import errors (stdio server blocks as expected)🤖 Generated with Claude Code