Skip to content

fix: wait for DSC v2 API and add DB migration for MLflow deploy#1188

Merged
Gkrumbach07 merged 1 commit intomainfrom
fix/rhoai-mlflow-crd-wait
Apr 3, 2026
Merged

fix: wait for DSC v2 API and add DB migration for MLflow deploy#1188
Gkrumbach07 merged 1 commit intomainfrom
fix/rhoai-mlflow-crd-wait

Conversation

@Gkrumbach07
Copy link
Copy Markdown
Contributor

@Gkrumbach07 Gkrumbach07 commented Apr 3, 2026

Summary

  • Fixes the deploy-rhoai-mlflow GHA job that's still failing after fix: wait for DataScienceCluster CRD before applying DSC #1187
  • The CRD wait was checking for CRD existence (v1 was already there), but the DSC manifest uses v2 which gets registered later
  • Now waits for v2 to appear in oc api-resources before applying
  • Also includes: MLflow replicas set to 1, DB migration step for existing PostgreSQL instances

Root cause

The RHOAI operator registers the DataScienceCluster CRD with v1 first, then updates it to include v2. The previous wait found v1 and proceeded, but the datasciencecluster.opendatahub.io/v2 DSC manifest failed because v2 wasn't served yet.

Test plan

  • Re-run the deploy-rhoai-mlflow job and verify it passes
  • Verify the v2 API wait step logs show it waiting then succeeding

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated deployment readiness validation to check for API availability in release and component build workflows.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b7e12e39-dd99-445a-9efc-6fb0a4a50d7f

📥 Commits

Reviewing files that changed from the base of the PR and between 2118509 and b29ac57.

📒 Files selected for processing (2)
  • .github/workflows/components-build-deploy.yml
  • .github/workflows/prod-release-deploy.yaml

📝 Walkthrough

Walkthrough

Two deployment workflow files were updated to change readiness verification for the DataScienceCluster API. The deployment wait steps now check for v2 API availability using oc api-resources and grep filtering instead of checking for CRD registration status.

Changes

Cohort / File(s) Summary
Deployment Readiness Checks
.github/workflows/components-build-deploy.yml, .github/workflows/prod-release-deploy.yaml
Updated deployment readiness verification from oc get crd datascienceclusters.datasciencecluster.opendatahub.io to oc api-resources --api-group=datasciencecluster.opendatahub.io | grep v2. Log messages and timeout errors updated from "CRD" to "v2 API" terminology.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows Conventional Commits format (fix: scope description) and accurately reflects the main change of updating the deployment wait step from CRD v1 to v2 API checking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Performance And Algorithmic Complexity ✅ Passed Workflow changes introduce no performance regressions; polling loops are bounded (600s timeout) with explicit breaks, K8s API calls are lightweight, and grep performs simple substring matching without expensive operations.
Security And Secret Handling ✅ Passed Workflow changes maintain security best practices: secrets properly masked via GitHub Actions, v2 API wait logic uses hardcoded commands with no injection vectors, database operations use safe hardcoded SQL, no sensitive data exposed.
Kubernetes Resource Safety ✅ Passed PR modifies only GitHub Actions workflows, not Kubernetes manifests. Kubernetes Resource Safety check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rhoai-mlflow-crd-wait
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/rhoai-mlflow-crd-wait

Comment @coderabbitai help to get the list of available commands and usage tips.

The CRD exists with v1 from the initial operator install, but the v2
version is registered later. The previous check found the v1 CRD and
proceeded, then the v2 DSC apply failed. Now checks that the v2 API
is actually served before applying.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Gkrumbach07 Gkrumbach07 force-pushed the fix/rhoai-mlflow-crd-wait branch from 5086eb1 to b29ac57 Compare April 3, 2026 13:45
@Gkrumbach07 Gkrumbach07 merged commit 7d9f8c7 into main Apr 3, 2026
39 checks passed
@Gkrumbach07 Gkrumbach07 deleted the fix/rhoai-mlflow-crd-wait branch April 3, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant