fix: wait for DSC v2 API and add DB migration for MLflow deploy#1188
Merged
Gkrumbach07 merged 1 commit intomainfrom Apr 3, 2026
Merged
fix: wait for DSC v2 API and add DB migration for MLflow deploy#1188Gkrumbach07 merged 1 commit intomainfrom
Gkrumbach07 merged 1 commit intomainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo deployment workflow files were updated to change readiness verification for the DataScienceCluster API. The deployment wait steps now check for v2 API availability using Changes
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
The CRD exists with v1 from the initial operator install, but the v2 version is registered later. The previous check found the v1 CRD and proceeded, then the v2 DSC apply failed. Now checks that the v2 API is actually served before applying. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5086eb1 to
b29ac57
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-rhoai-mlflowGHA job that's still failing after fix: wait for DataScienceCluster CRD before applying DSC #1187v2to appear inoc api-resourcesbefore applyingRoot cause
The RHOAI operator registers the
DataScienceClusterCRD with v1 first, then updates it to include v2. The previous wait found v1 and proceeded, but thedatasciencecluster.opendatahub.io/v2DSC manifest failed because v2 wasn't served yet.Test plan
deploy-rhoai-mlflowjob and verify it passes🤖 Generated with Claude Code
Summary by CodeRabbit