-
Notifications
You must be signed in to change notification settings - Fork 82
feat(control-plane): CP /token endpoint for runner gRPC auth RHOAIENG-56711 #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5944d7f
docs(control-plane): spec CP token endpoint for runner gRPC auth rene…
2a75017
docs(spec): remove BOT_TOKEN Secret — CP endpoint is sole token source
660c0f7
feat(control-plane): implement CP /token endpoint for runner gRPC aut…
8833cce
fix(control-plane): create NetworkPolicy allowing api-server to reach…
42092fe
fix(control-plane,runner): address CodeRabbit review comments on PR #…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make
CP_TOKEN_URLrequired for kube session pods.Line 77 leaves the new auth path optional, but the reconciler now injects only
AMBIENT_CP_TOKEN_URL, and the runner falls back toBOT_TOKENonly when that value is empty. Since this PR removesBOT_TOKENinjection, omittingCP_TOKEN_URLleaves provisioned runner/MCP pods with no credential source and they fail auth on startup/reconnect.Suggested fix
switch cfg.PlatformMode { case "standard", "mpp": default: return nil, fmt.Errorf("unknown PLATFORM_MODE %q: must be one of standard, mpp", cfg.PlatformMode) } + + if cfg.Mode == "kube" && cfg.CPTokenURL == "" { + for _, name := range cfg.Reconcilers { + if name == "kube" { + return nil, fmt.Errorf("CP_TOKEN_URL must be set when the kube reconciler is enabled") + } + } + } return cfg, nil }🤖 Prompt for AI Agents