fix(runner): use unbounded SSE tap queue#1220
Merged
markturansky merged 1 commit intoalphafrom Apr 6, 2026
Merged
Conversation
The bounded queue (maxsize=100) dropped events when no SSE consumer was connected (e.g. CLI sessions, background agent runs). Each session queue is ephemeral and drained or GC'd at run end, so unbounded buffering is safe — worst case is transient memory growth during a long turn with no consumer, which is acceptable given pod memory limits (4Gi). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThese changes remove the 100-item capacity limit from async queues in SSE (Server-Sent Events) stream initialization, allowing unbounded queue sizes in both the bridge pre-registration and per-thread stream endpoints. Changes
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxsize=100, causing silent event drops when no consumer was connected (CLI sessions, background agent runs, slow frontends)Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit