fix(manifests): wire and correct MCP sidecar image name in mpp-openshift overlay#1273
Merged
markturansky merged 1 commit intoalphafrom Apr 10, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated MCP image references across Kubernetes manifest overlays from Changes
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
markturansky
force-pushed
the
fix/mcp-image-name-mpp-openshift
branch
from
ebdb802 to
6d6d8d8
Compare
vteam_ambient_mcp does not exist on Quay; correct name is vteam_mcp. Fixes ImagePullBackOff on runner pods in mpp-openshift. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
components/manifests/overlays/mpp-openshift/ambient-api-server.yaml (1)
55-77:⚠️ Potential issue | 🟠 MajorAdd resources for the
migrationinitContainer to avoid policy/admission failures.At Line 55, the initContainer has no
resources.requests/resources.limits. In OpenShift/Kubernetes environments with enforced policies, this can block pod creation.Proposed patch
initContainers: - name: migration image: quay.io/ambient_code/vteam_api_server:latest imagePullPolicy: Always + resources: + requests: + cpu: 50m + memory: 128Mi + limits: + cpu: 200m + memory: 256Mi command: - /usr/local/bin/ambient-api-serverAs per coding guidelines, "
components/manifests/**/*.yaml: ... Resource limits/requests required on containers."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/manifests/overlays/mpp-openshift/ambient-api-server.yaml` around lines 55 - 77, The initContainer named "migration" is missing resources which will fail enforced admission policies; add a resources block to that initContainer (under the initContainers entry for the container named migration) including resources.requests (cpu and memory) and resources.limits (cpu and memory) with reasonable values for the job (e.g., small request and slightly higher limit) so the pod will pass OpenShift/Kubernetes policy checks; ensure the resources stanza is present alongside volumeMounts/securityContext for the "migration" initContainer.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@components/manifests/overlays/mpp-openshift/ambient-api-server.yaml`:
- Around line 55-77: The initContainer named "migration" is missing resources
which will fail enforced admission policies; add a resources block to that
initContainer (under the initContainers entry for the container named migration)
including resources.requests (cpu and memory) and resources.limits (cpu and
memory) with reasonable values for the job (e.g., small request and slightly
higher limit) so the pod will pass OpenShift/Kubernetes policy checks; ensure
the resources stanza is present alongside volumeMounts/securityContext for the
"migration" initContainer.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b818e709-349e-4547-bb16-82ca56b1ddec
📒 Files selected for processing (4)
components/manifests/overlays/mpp-openshift/ambient-api-server.yamlcomponents/manifests/overlays/mpp-openshift/ambient-control-plane.yamlcomponents/manifests/overlays/mpp-openshift/kustomization.yamlcomponents/runners/ambient-runner/ambient_runner/endpoints/events.py
markturansky
force-pushed
the
fix/mcp-image-name-mpp-openshift
branch
from
6d6d8d8 to
afc741d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ambient-mcpsidecar into the mpp-openshift control-plane deployment (MCP_IMAGE+MCP_API_SERVER_URLenv vars)vteam_ambient_mcp(non-existent) tovteam_mcp(the actual Quay repo)vteam_mcpto the kustomize image override blockFixes
ImagePullBackOffon runner pods in mpp-openshift caused by the wrong image name.Test plan
ImagePullBackOffMCP_IMAGE=quay.io/ambient_code/vteam_mcp:latestin control-plane deployment env🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes