Skip to content

fix: repair invalid JSON in prd-rfe-workflow, add CI lint#60

Merged
jeremyeder merged 1 commit intoambient-code:mainfrom
jeremyeder:fix/prd-rfe-ambient-json-lint
Mar 9, 2026
Merged

fix: repair invalid JSON in prd-rfe-workflow, add CI lint#60
jeremyeder merged 1 commit intoambient-code:mainfrom
jeremyeder:fix/prd-rfe-ambient-json-lint

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

  • Fix missing comma in workflows/prd-rfe-workflow/.ambient/ambient.json between results and rubric objects
  • Add lint-workflows.yml GitHub Actions workflow to prevent this in the future

What was broken

The invalid JSON caused the platform backend to silently fail parsing ambient.json for the PRD RFE workflow. As a result:

  • No name → fell back to directory name ("Prd Rfe Workflow" instead of "Create PRDs and RFEs")
  • No description → empty description in UI
  • No startupPrompt → no greeting shown when workflow is activated

CI Lint checks

The new GHA validates on every push/PR touching workflows/:

  1. JSON validity — all ambient.json files must be parseable (fails CI if not)
  2. Required fields — warns if name, description, or startupPrompt are missing
  3. Directory structure — every workflow must have .ambient/ambient.json

🤖 Generated with Claude Code

Missing comma between "results" and "rubric" objects caused the backend
to silently fail parsing ambient.json, resulting in no name, description,
or startupPrompt being served for the PRD RFE workflow.

Also adds a GitHub Actions workflow that validates:
- All ambient.json files are valid JSON
- Required fields (name, description, startupPrompt) are present
- Workflow directory structure includes .ambient/ambient.json

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremyeder jeremyeder merged commit 6162898 into ambient-code:main Mar 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant