Skip to content

chore: disable prd-rfe-workflow from OOTB listing#87

Merged
jeremyeder merged 2 commits intomainfrom
disable-prd-rfe-workflow
Mar 26, 2026
Merged

chore: disable prd-rfe-workflow from OOTB listing#87
jeremyeder merged 2 commits intomainfrom
disable-prd-rfe-workflow

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

Depends on

🤖 Generated with Claude Code

Set `"enabled": false` so this workflow is excluded from the
platform UI workflow picker. Requires ambient-code/platform#1054.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Added an "enabled": false flag to workflows/prd-rfe-workflow/.ambient/ambient.json, and extended the ambient config schema/documentation (AMBIENT_JSON_SCHEMA.md) with three optional fields: enabled?: boolean, greeting?: string, and rubric?: { activationPrompt: string; schema: object }.

Changes

Cohort / File(s) Summary
Workflow Configuration
workflows/prd-rfe-workflow/.ambient/ambient.json
Added top-level "enabled": false flag to disable the workflow while keeping all existing configuration fields unchanged.
Ambient JSON Schema / Docs
AMBIENT_JSON_SCHEMA.md
Extended AmbientConfig documentation with optional fields enabled, greeting, and rubric (descriptions, defaults, and examples); clarified optional fields and summary counts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: disabling the prd-rfe-workflow from the out-of-the-box listing.
Description check ✅ Passed The description is directly related to the changeset, explaining why the 'enabled': false flag was added and its expected effect with platform support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disable-prd-rfe-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@workflows/prd-rfe-workflow/.ambient/ambient.json`:
- Line 2: The schema docs are missing optional fields used in ambient.json;
update AMBIENT_JSON_SCHEMA.md to document the "enabled" boolean (controls
whether the ambient config is active), the "greeting" string (optional
user-facing welcome message), and the "rubric" object or string (optional
guidance/rules for behavior), marking them optional and adding short purpose
descriptions and example values; ensure the schema section references these
three fields and the expected types so future loaders/maintainers can find and
validate them.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: df3fe733-8b76-49d6-8ae3-4357eb7cf10a

📥 Commits

Reviewing files that changed from the base of the PR and between 4a058d0 and 7adb0ba.

📒 Files selected for processing (1)
  • workflows/prd-rfe-workflow/.ambient/ambient.json

Adds documentation for optional ambient.json fields that were in use
but not documented in AMBIENT_JSON_SCHEMA.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremyeder jeremyeder merged commit 169f87c into main Mar 26, 2026
1 of 2 checks passed
jeremyeder added a commit that referenced this pull request Mar 26, 2026
This workflow was disabled in #87 and is no longer needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder added a commit that referenced this pull request Mar 26, 2026
This workflow was disabled in #87 and is no longer needed.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant