Skip to content

gpu memory check - #295

Merged
alexandraBara merged 5 commits into
developmentfrom
jaspal_gpuchecks
Sep 30, 2026
Merged

alexandraBara merged 5 commits into
developmentfrom
jaspal_gpuchecks

Conversation

@jaspals3123

Copy link
Copy Markdown
Collaborator

added new analyzer arg minimum_available_percent
Plugin config:

{
  "name": "GPU memory validation",
  "plugins": {
    "AmdSmiPlugin": {
      "collection_args": {},
      "analysis_args": {
        "gpu_memory": {
          "minimum_available_percent": 95
        }
      }
    }
  }
}

cmd:
node-scraper --plugin-configs=/home/jaspals/node-scraper/plugin.json

)
continue

if total_value <= 0:

@alexandraBara alexandraBara Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this ever going to happen? this seems like something we should check for before we try and compute it in such a way that it gives negative values

Comment on lines 487 to 498

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no additional checks are added for the potentially offensive values, then this should be made comprehensive:

if (
    not math.isfinite(total_value)
    or not math.isfinite(free_value)
    or total_value <= 0
    or free_value < 0
    or total_vram.unit != free_vram.unit
):
    self._log_event(
        category=EventCategory.PLATFORM,
        description=(
            f"GPU {metric.gpu} VRAM values are invalid "
            f"(total={total_vram.value} {total_vram.unit}, "
            f"free={free_vram.value} {free_vram.unit})"
        ),
        ...
    )
    continue

@alexandraBara
alexandraBara merged commit db5ac59 into development Sep 30, 2026
7 checks passed
@alexandraBara
alexandraBara deleted the jaspal_gpuchecks branch September 30, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants