feat: business validation checks#33
Merged
Merged
Conversation
Add four validation checks in the validation package: 1. Isolated entities (warning): components and systems with no requires or provides interfaces are flagged as incomplete from a business perspective. The architecture remains valid. 2. Connection cycles (error): detects directed cycles in the connection graph within each system/component scope using DFS with three-colour marking. 3. Type definition cycles (error): detects recursive type or interface definitions where NamedTypeRef fields form a cycle, including cycles through List<T>, Optional<T>, and Map<K,V>. 4. Interface propagation (error): non-leaf systems and components that declare requires/provides must have at least one direct member that declares the same interface. Expose ValidationWarning, ValidationError, ValidationResult, and validate() through validation/__init__.py. Add comprehensive tests covering positive and negative cases for all four checks, including edge cases such as versioned interface matching, nested scopes, qualified name usage in messages, and multi-check failures reported together. Co-authored-by: Andi Hellmund <amhellmund@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the four business validation checks described in issue #32:
Closes #32
Generated with Claude Code