Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset of system velocity in model.step #278

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix reset of system velocity in model.step #278

merged 1 commit into from
Oct 31, 2024

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Oct 31, 2024 •
edited
Loading

This PR fixes a regression on the reset of the system velocity in model.step for rigid contacts.

📚 Documentation preview 📚: https://jaxsim--278.org.readthedocs.build//278/

@xela-95 xela-95 self-assigned this Oct 31, 2024
flferretti
flferretti approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @xela-95! LGTM

@flferretti flferretti enabled auto-merge October 31, 2024 16:04
@flferretti flferretti merged commit 35cf336 into ami-iit:main Oct 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoferigo diegoferigo diegoferigo approved these changes

@flferretti flferretti flferretti approved these changes

Assignees

@xela-95 xela-95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xela-95 @diegoferigo @flferretti