Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit model contact parameters and gravity in js.model.reduce #372

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Feb 14, 2025

This PR fixes the js.model.reduce function to inherit model contact parameters and gravity, improving consistency and functionality.


📚 Documentation preview 📚: https://jaxsim--372.org.readthedocs.build//372/

@flferretti flferretti requested a review from xela-95 as a code owner February 14, 2025 09:34
@flferretti flferretti self-assigned this Feb 14, 2025
Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flferretti flferretti merged commit 9b606f2 into main Feb 14, 2025
19 of 25 checks passed
@flferretti flferretti deleted the fix/model_reduce branch February 14, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants