Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Runge-Kutta 4 integrator #373

Merged
merged 12 commits into from
Feb 18, 2025
Merged

Implement Runge-Kutta 4 integrator #373

merged 12 commits into from
Feb 18, 2025

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Feb 14, 2025

This PR introduces a new Runge-Kutta 4 integration method and an Integrator enum to select between available simulation integrators. Moreover, it adds NaN checks for quaternions and add a pytest fixture for testing different integrators and updates the JaxSimModel to support integrator selection.


📚 Documentation preview 📚: https://jaxsim--373.org.readthedocs.build//373/

@flferretti flferretti requested a review from xela-95 as a code owner February 14, 2025 17:01
@flferretti flferretti self-assigned this Feb 14, 2025
Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!
I added a couple of minor comments

Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I really like the simplicity of the implementation! Left some minor comments

@flferretti flferretti merged commit 1b31e66 into main Feb 18, 2025
18 of 24 checks passed
@flferretti flferretti deleted the feature/rk4 branch February 18, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants