-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Codespaces support #81
Conversation
16b633b
to
d224abc
Compare
d036090
to
13f7623
Compare
Yes, this is due to https://conda-forge.org/docs/maintainer/knowledge_base.html#libgl . Unfortunatly there there is no docs on which apt packages should be installed, but via apt-file:
so I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks! For reference I was worried about possible billing for the ami-iit organization, but after reading https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/choosing-who-owns-and-pays-for-codespaces-in-your-organization we should be good to go (we have a 0€ limit for Codespaces). |
13f7623
to
a2257f6
Compare
Yep I can confirm that
Good point, I didn't think of billings. How does it work, do we have some free hours included? I just checked my personal account since I was originally thinking that it would have consumed my free hours, but it seems that I didn't consume any. |
I don't think so, there is a " A $0 limit will prevent your organization from using Codespaces " notice under the limit. |
Ok, if we start facing any problem I guess we can change the settings at that time. Here I found the following:
Since we all can get a Pro account within AMI, switching to user-owned codespaces might be the best choice - if it's not already the case. |
This PR adds the bare minimum resources to obtain a GitHub Codespace with the following features:
This should help the process of on-the-fly editing and reviewing.
Here below further details:
devcontainer.json
was taken by this template.The steps to open a codespace is the following:
Code > Create workspace in devcontainer
.jaxsim
conda environment generated from the yaml file ready and active (checkwhich python
).Now the project is ready to be navigated. It is not necessary to install the project in editable mode if no code needs to be executed. VSCode automatically detects the sources in
src/
and Ctrl+click should work fine. Otherwise, to e.g. run any code (tests included), the project can be installed as follows:pip install --no-deps -e .
Other notes:
~/.bashrc
initialization done by the micromamba feature. Regardless, I managed to work around the problems as explained.postCreateCommand
ofdevcontainer.json
but either it doesn't run in shell that is initialized with the conda environment, or it runs too early when the environment is not ready. If the problem is the first one, probably we can do it by defining a containerentrypoint.sh
.devcontainer.json
: https://containers.dev/implementors/json_reference/.Running the tests now fail due to:
I'm not interested to fix this at this stage. cc FYI @traversaro, likely I need to install some missing system dependency or GL support in the conda environment.
📚 Documentation preview 📚: https://jaxsim--81.org.readthedocs.build//81/