-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit configuration #86
Conversation
Mmh I never liked too much the idea behind committed pre-commits, but in the same time I never investigated in much depth the approach. I want to know more what's your experience with them. What I dislike is that often I create WIP commits locally (and also push them remotely), and in most cases they are not compliant with the pre-commits rules. I don't want those commits to get blocked or require any additional effort on my side. We do have CI tests before merging PRs for this. Since these rules get hooked into your personal git configuration, is it an option to just keep them local? |
@flferretti can you add a line or two either in the README or somewhere where you see fit explaining either how to use this pre-commit files, or a link to related documentation? I guess most members of AMI (that could contribute to the library) are not aware of how this work. |
Sure @traversaro! What about adding a |
Sure, as you prefer. |
@traversaro I opened #87 to add a |
I found interesting information for beginners in the following blog post: |
This PR adds a pre-commit configuration file that includes hooks for checking AST, merge conflicts, YAML syntax, end-of-file, trailing whitespace, and code formatting using Black and isort.
📚 Documentation preview 📚: https://jaxsim--86.org.readthedocs.build//86/