First working version of osqp-matlab-cmake-buildsystem #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2021
|
Hi @traversaro , I had reviewed most of the changes in this PR, so I thought I could finish the review even if we close robotology/robotology-superbuild#575 and this PR without merging it. What do you think? |
|
Ok! |
|
Given that there are some uses of osqp-matlab in the lab outside of https://github.com/dic-iit/matlab-whole-body-simulator, I think we can proceed with this PRs. |
Co-authored-by: Nuno Guedelha <[email protected]>
Co-authored-by: Nuno Guedelha <[email protected]>
|
The example https://github.com/oxfordcontrol/osqp-matlab/blob/master/examples/easy_lasso_qp.m is also working for me after building the repo. LGTM. |
nunoguedelha
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the relevant information is provided in the README. This is convenient to easily add the osqp-matlab to the robotology-superbuild, to fix robotology/robotology-superbuild#575 .
There are a few upstream problems:
But for the time being the repo contains local workaround that should be easy to revert once the issue are solved.
I already tested the bindings with the example https://github.com/oxfordcontrol/osqp-matlab/blob/master/examples/easy_lasso_qp.m and they seem to be working fine. Once this is merged, I will release the version
v0.6.2.0.