Conversation
Separate the sidebar into a home view (notes + settings link) and a settings sub-view with back navigation. Update default route to /settings/notes, add legacy route mappings, and fix widget notification navigation paths.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds a Back-to-home locale key, splits home vs settings navigation items, updates the settings sidebar to render a back link on settings routes, adds legacy route normalization for navigation, and changes error-notification redirect targets and root route redirect. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Derive isHomeSidebar from SETTINGS_NAV_ITEMS instead of hardcoding, so any new home-level routes automatically get the home sidebar - Move LEGACY_ROUTE_MAP outside component to avoid recreating on mount - Add /settings -> /settings/preferences to legacy map - Update NETWORK_ERROR navigateTo from /settings to /settings/preferences
- Parse query strings from route URLs and pass them as typed search params to router.navigate() instead of inlining in the `to` field - Treat bare /settings and /settings/ as settings routes to prevent brief home sidebar flash during the index redirect
Summary
/settings/historyto/settings/notes/historyand/settings/accountTest plan
/settings/notesSummary by CodeRabbit
New Features
Improvements