Fix false power/water warnings for non-building tiles#421
Open
Fix false power/water warnings for non-building tiles#421
Conversation
Improved filtering to exclude terrain and infrastructure (water, road, bridge, empty) when counting unpowered and unwatered buildings, fixing false warnings about missing power/water. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Your pull request is now ready for review with Assert. Stop waiting for your code to break. Ship with confidence using Assert. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Only count actual zoned buildings (exclude terrain, infrastructure, and placeholders) | ||
| const btype = tile.building.type; | ||
| if (tile.zone !== 'none' && btype !== 'grass' && btype !== 'water' && | ||
| btype !== 'road' && btype !== 'bridge' && btype !== 'empty') { |
There was a problem hiding this comment.
Missing tree in non-building type exclusion filter
Medium Severity · Logic Bug
The filter excludes grass, water, road, bridge, and empty from unpowered/unwatered counts, but misses tree. Zoning can be applied to tree tiles (see allowedTypesForZoning which includes 'tree'), so zoned tree tiles will have powered: false and watered: false and be incorrectly counted as unpowered/unwatered buildings. The NO_CONSTRUCTION_TYPES constant groups tree alongside all the other excluded types, confirming it belongs in this filter too.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the advisor message filtering to exclude terrain and infrastructure tiles (water, road, bridge, empty) when counting unpowered and unwatered buildings. This prevents false warnings about missing power or water for tiles that don't represent actual buildings.
Changes made:
🤖 Generated with Claude Code
Note
Low Risk
Small change to advisor message counting logic only; low risk aside from potentially changing when utility warnings appear.
Overview
Fixes false Power/Water advisor warnings by tightening the
generateAdvisorMessagescounters to only include actual zoned buildings and exclude non-building tile types (water,road,bridge,empty, in addition tograss).Also does a tiny micro-optimization by caching
tile.building.typeintobtypewhile scanning the grid.Written by Cursor Bugbot for commit 91e4d0a. This will update automatically on new commits. Configure here.