Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable comment support by default + fix: use files trailing arguments in Node + fix: confirm minification of files with unknown extension + fix: warn on not finding any files #25

Merged
merged 5 commits into from
Sep 10, 2024
+177 −95
Merged

feat: enable comment support by default + fix: use files trailing arguments in Node + fix: confirm minification of files with unknown extension + fix: warn on not finding any files #25

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
678a65c
fix: use files trailing arguments in Node
aminya Sep 10, 2024
597fccc
fix: confirm minification of files with unknown extension
aminya Sep 10, 2024
961c7d7
fix: warn on not finding any files
aminya Sep 10, 2024
034b4e5
perf: separate no-comment minifier for better performance
aminya Sep 10, 2024
b5f68d2
feat: enable comment support by default
aminya Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: warn on not finding any files
@aminya
aminya committed Sep 10, 2024
commit 961c7d78ca51ee9d3896445160686b6587d1ef9d
6 changes: 6 additions & 0 deletions src/native/lib.d
View file
Original file line number Diff line number Diff line change
@@ -224,6 +224,12 @@ void minifyFiles(in string[] paths, in bool hasComment = false) @trusted
}
}).joiner().array();

if (files.empty)
{
writeln("No files found.");
return;
}

if (!confirmExtension(files))
{
return;