Convert SocketException to guzzle ConnectException #3
Conversation
| } catch (SocketException $e) { | ||
| $promise->reject(new ConnectException($e->getMessage(), $request, $e)); |
There was a problem hiding this comment.
I guess this is not always right, e.g. if a socket is closed while the request is sent, we likely don't want a ConnectException?
There was a problem hiding this comment.
Agreed, it might be better to handle this the same way as in CurlFactory.php, where only certain types of errors are converted to ConnectException, while all others are converted to RequestException.
But all raw SocketException should definitely be converted to either ConnectException or RequestException to be compatible with Guzzle, which always throws its own internal exceptions in such cases. Applications rely on these Guzzle exceptions, and they must remain consistent no matter what handler is used under the hood.
The only problem is that we cannot differentiate between SocketException cases. We need to add some form of differentiation to implement this properly.
See my related issue about this: amphp/http-client#379
Convert
Amp\Http\Client\SocketExceptionto guzzleGuzzleHttp\Exception\ConnectException