SPI Engine abstraction #1948
Open
SPI Engine abstraction #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBFFilho
force-pushed
the
spi_engine_abstraction
branch
from
eeb0677 to
abf9ede
Compare
LBFFilho
requested review from
AndreiGrozav,
PIoandan,
PopPaul2021,
acostina,
gastmaier,
ladace,
podgori and
sarpadi
as code owners
Contributor
Author
|
RetriggerCI |
1 similar comment
Collaborator
|
RetriggerCI |
Signed-off-by: Laez Barbosa <[email protected]>
LBFFilho
force-pushed
the
spi_engine_abstraction
branch
from
abf9ede to
67b670e
Compare
Ad intel-compatible ad_* commands to the carrier common _qsys.tcl Now the same spi engine script is used for xilinx and intel projects. Other vendors can be added to the script in the future. Signed-off-by: Laez Barbosa <[email protected]>
Signed-off-by: Laez Barbosa <[email protected]>
LBFFilho
force-pushed
the
spi_engine_abstraction
branch
from
67b670e to
3cd151e
Compare
caosjr
reviewed
Nov 25, 2025
Contributor
caosjr
left a comment
caosjr
left a comment
There was a problem hiding this comment.
I have compiled ad4052 project with the main branch and this branch under the quartus 24.1, they have very similar output. The spi_engine script seems much clearer in this mode avoiding unnecessary code in the tcl of the projects.
Contributor
|
I have compiled all the modified projects. Timing closure seems to be better for the AD57XX in this environment, I did not have to recompile as I did in the main branch. |
caosjr
requested changes
Nov 26, 2025
Contributor
caosjr
left a comment
caosjr
left a comment
There was a problem hiding this comment.
Before approving I think it is worth a second check on the projects. Every project were consuming less registers than in the main branch, maybe there is some misconnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Unifies SPI Engine projects for different vendors (Xilinx & Altera for now) into a single script. It uses intel implementations of the ad_* procs to keep vendor-specific lines to a minimum
This is implemented with a separate adi_board_intel.tcl, now sourced in the carrier-specific tcl, since that's where the intel commands were defined. Note that these methods are not spi engine specific, so that's a direction we could explore in the future. We could in the future move these intel procs to adi_board.tcl and have everything in a single place.
PR Type
PR Checklist