Add Support for LTC3208 #3022
Open
Add Support for LTC3208 #3022
+559
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcroleda
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
jcroleda
force-pushed
the
staging/ltc3208
branch
3 times, most recently
from
47e5181 to
d2fada2
Compare
edelweiseescala
left a comment
edelweiseescala
left a comment
There was a problem hiding this comment.
Hello, just sharing what I've learned so far
jcroleda
force-pushed
the
staging/ltc3208
branch
from
d2fada2 to
57ca070
Compare
Author
|
Changelog V2:
|
Add Documentation for LTC3208 Multidisplay LED Driver. Signed-off-by: Jan Carlo Roleda <[email protected]>
Kernel driver implementation for LTC3208 Multidisplay LED Driver Signed-off-by: Jan Carlo Roleda <[email protected]>
Add entry to Kconfig for LTC3208 driver Signed-off-by: Jan Carlo Roleda <[email protected]>
jcroleda
force-pushed
the
staging/ltc3208
branch
from
57ca070 to
999b8f4
Compare
| for (i = 0; i < LTC3208_NUM_AUX_LEDS; i++) { | ||
| ret = device_property_match_string(&client->dev, | ||
| ltc3208_dt_aux_channels[i], | ||
| str_val); |
There was a problem hiding this comment.
str_val doesnt seem to have been initialized
| #define LTC3208_MAX_BRIGHTNESS_8BIT 0xFF | ||
|
|
||
| #define LTC3208_NUM_LED_GRPS 8 | ||
| #define LTC3208_NUM_AUX_LEDS 3 |
There was a problem hiding this comment.
based on line 314, should this be 4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR Type
PR Checklist