Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on the commit subject. Don't mention "binding" in the subject. It is already obvious and the maintainers will complain it. See the git log for examples. Also, the binding should come before the driver changes.

%YAML 1.2
---
$id: http://devicetree.org/schemas/iio/amplifiers/adi,ad8366.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: AD8366, similar Gain Amplifiers and Digital Attenuators

maintainers:
- Michael Hennerich <[email protected]>
- Rodrigo Alencar <[email protected]>

description: |
Digital Variable Gain Amplifiers (VGAs) and Digital Attenuators with
SPI interface.
Supported devices:
* AD8366 Dual-Digital Variable Gain Amplifier (VGA)
* ADA4961: BiCMOS RF Digital Gain Amplifier (DGA)
* ADL5240: Digitally controlled Variable Gain Amplifier (VGA)
* ADRF5720: Silicon Digital Attenuator
* ADRF5730: Silicon Digital Attenuator
* ADRF5731: Silicon Digital Attenuator
* HMC271A: Digital Attenuator
* HMC792A: GaAs MMIC Digital Attenuator
* HMC1018A: GaAs MMIC Digital Attenuator
* HMC1019A: GaAs MMIC Digital Attenuator
* HMC1119: Silicon Digital Attenuator
properties:
compatible:
enum:
- adi,ad8366
- adi,ada4961
- adi,adl5240
- adi,adrf5720
- adi,adrf5730
- adi,adrf5731
- adi,hmc271a
- adi,hmc792a
- adi,hmc1018a
- adi,hmc1019a
- adi,hmc1119

reg:
maxItems: 1

vcc-supply:
description: Regulator that provides power to the device.

reset-gpios:
maxItems: 1
description:
GPIO pin used to reset the device.

enable-gpios:
maxItems: 1
description:
GPIO pin used to enable the device.

required:
- compatible
- reg
- vcc-supply

allOf:
- $ref: /schemas/spi/spi-peripheral-props.yaml#

unevaluatedProperties: false

examples:
- |
#include <dt-bindings/gpio/gpio.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
amplifier@0 {
compatible = "adi,ad8366";
reg = <0>;
spi-max-frequency = <1000000>;
vcc-supply = <&vcc_3v3>;
};
};
- |
#include <dt-bindings/gpio/gpio.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
attenuator@1 {
compatible = "adi,adrf5730";
reg = <1>;
spi-max-frequency = <1000000>;
vcc-supply = <&vcc_3v3>;
};
};
...
9 changes: 9 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -1566,6 +1566,15 @@ W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
F: drivers/iio/adc/ad7780.c

ANALOG DEVICES INC AD8366 DRIVER
M: Michael Hennerich <[email protected]>
M: Rodrigo Alencar <[email protected]>
L: [email protected]
S: Supported
W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
F: drivers/iio/amplifiers/ad8366.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of changes for one patch. Do one logical change per patch if you really want to modernize it.


ANALOG DEVICES INC AD9467 DRIVER
M: Michael Hennerich <[email protected]>
M: Nuno Sa <[email protected]>
Expand Down
6 changes: 6 additions & 0 deletions drivers/iio/amplifiers/Kconfig
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# SPDX-License-Identifier: GPL-2.0
#
# Gain Amplifiers, etc.
Expand All @@ -18,7 +18,13 @@
AD8366 Dual-Digital Variable Gain Amplifier (VGA)
ADA4961 BiCMOS RF Digital Gain Amplifier (DGA)
ADL5240 Digitally controlled variable gain amplifier (VGA)
ADRF5720: 0.5 dB LSB, 6-Bit, Silicon Digital Attenuator
ADRF5730: 0.5 dB LSB, 6-Bit, Silicon Digital Attenuator
ADRF5731: 2 dB LSB, 4-Bit, Silicon Digital Attenuator
HMC271A: 1dB LSB 5-Bit Digital Attenuator SMT
HMC792A 0.25 dB LSB GaAs MMIC 6-Bit Digital Attenuator
HMC1018A: 1.0 dB LSB GaAs MMIC 5-BIT Digital Attenuator
HMC1019A: 0.5 dB LSB GaAs MMIC 5-BIT Digital Attenuator
HMC1119 0.25 dB LSB, 7-Bit, Silicon Digital Attenuator

To compile this driver as a module, choose M here: the
Expand Down
Loading
Loading