-
Notifications
You must be signed in to change notification settings - Fork 913
AD8366 Driver upstream update #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rodrigo455
wants to merge
6
commits into
mirror_ci/jic23/iio/testing
Choose a base branch
from
staging/jic23_iio_ad8366-update
base: mirror_ci/jic23/iio/testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+317
−173
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8149e1f
iio: amplifiers: ad8366: driver update and dt support
rodrigo455 16b1563
dt-bindings: iio: amplifiers: Add AD8366
rodrigo455 0a066cb
iio: amplifiers: ad8366: Update device support
commodo 02cd171
iio: amplifiers: ad8366: use cleanup.h mutex guard
rodrigo455 83630a9
iio: amplifiers: ad8366: simplify resource management
rodrigo455 02e319f
iio: amplifiers: ad8366: add device tree support
rodrigo455 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
98 changes: 98 additions & 0 deletions
98
Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/iio/amplifiers/adi,ad8366.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: AD8366, similar Gain Amplifiers and Digital Attenuators | ||
|
|
||
| maintainers: | ||
| - Michael Hennerich <[email protected]> | ||
| - Rodrigo Alencar <[email protected]> | ||
|
|
||
| description: | | ||
| Digital Variable Gain Amplifiers (VGAs) and Digital Attenuators with | ||
| SPI interface. | ||
| Supported devices: | ||
| * AD8366 Dual-Digital Variable Gain Amplifier (VGA) | ||
| * ADA4961: BiCMOS RF Digital Gain Amplifier (DGA) | ||
| * ADL5240: Digitally controlled Variable Gain Amplifier (VGA) | ||
| * ADRF5720: Silicon Digital Attenuator | ||
| * ADRF5730: Silicon Digital Attenuator | ||
| * ADRF5731: Silicon Digital Attenuator | ||
| * HMC271A: Digital Attenuator | ||
| * HMC792A: GaAs MMIC Digital Attenuator | ||
| * HMC1018A: GaAs MMIC Digital Attenuator | ||
| * HMC1019A: GaAs MMIC Digital Attenuator | ||
| * HMC1119: Silicon Digital Attenuator | ||
| properties: | ||
| compatible: | ||
| enum: | ||
| - adi,ad8366 | ||
| - adi,ada4961 | ||
| - adi,adl5240 | ||
| - adi,adrf5720 | ||
| - adi,adrf5730 | ||
| - adi,adrf5731 | ||
| - adi,hmc271a | ||
| - adi,hmc792a | ||
| - adi,hmc1018a | ||
| - adi,hmc1019a | ||
| - adi,hmc1119 | ||
|
|
||
| reg: | ||
| maxItems: 1 | ||
|
|
||
| vcc-supply: | ||
| description: Regulator that provides power to the device. | ||
|
|
||
| reset-gpios: | ||
| maxItems: 1 | ||
| description: | ||
| GPIO pin used to reset the device. | ||
|
|
||
| enable-gpios: | ||
| maxItems: 1 | ||
| description: | ||
| GPIO pin used to enable the device. | ||
|
|
||
| required: | ||
| - compatible | ||
| - reg | ||
| - vcc-supply | ||
|
|
||
| allOf: | ||
| - $ref: /schemas/spi/spi-peripheral-props.yaml# | ||
|
|
||
| unevaluatedProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| #include <dt-bindings/gpio/gpio.h> | ||
| spi { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
| amplifier@0 { | ||
| compatible = "adi,ad8366"; | ||
| reg = <0>; | ||
| spi-max-frequency = <1000000>; | ||
| vcc-supply = <&vcc_3v3>; | ||
| }; | ||
| }; | ||
| - | | ||
| #include <dt-bindings/gpio/gpio.h> | ||
| spi { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
| attenuator@1 { | ||
| compatible = "adi,adrf5730"; | ||
| reg = <1>; | ||
| spi-max-frequency = <1000000>; | ||
| vcc-supply = <&vcc_3v3>; | ||
| }; | ||
| }; | ||
| ... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1566,6 +1566,15 @@ W: https://ez.analog.com/linux-software-drivers | |
| F: Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml | ||
| F: drivers/iio/adc/ad7780.c | ||
|
|
||
| ANALOG DEVICES INC AD8366 DRIVER | ||
| M: Michael Hennerich <[email protected]> | ||
| M: Rodrigo Alencar <[email protected]> | ||
| L: [email protected] | ||
| S: Supported | ||
| W: https://ez.analog.com/linux-software-drivers | ||
| F: Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | ||
| F: drivers/iio/amplifiers/ad8366.c | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a lot of changes for one patch. Do one logical change per patch if you really want to modernize it. |
||
|
|
||
| ANALOG DEVICES INC AD9467 DRIVER | ||
| M: Michael Hennerich <[email protected]> | ||
| M: Nuno Sa <[email protected]> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on the commit subject. Don't mention "binding" in the subject. It is already obvious and the maintainers will complain it. See the git log for examples. Also, the binding should come before the driver changes.