-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPC Analysis #16
base: master
Are you sure you want to change the base?
PPC Analysis #16
Conversation
@@ -1,4 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that config.json
probably shouldn't be checked in, but maybe we can check in a file like config.sample.json
w/ example parameters?
this looks great @henryhund. Keen to hear thoughts form @jthandy and @cmerrick |
@@ -0,0 +1,35 @@ | |||
create or replace view ac_hhund.facebook_ads_summary as ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace ac_hhund with {schema}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Two tiny comments otherwise I'm 👍 |
@jthandy refactored this to set up ppc as a model, rather than analyses. per our convo yesterday. |
This is a bit behind dbt at the moment; you really need to update these models to use current dbt conventions or it will cause builds from master to fail. Please LMK if you need help setting up dbt or with how to change your models in order to conform. |
No description provided.