feat: add ESLint configuration for frontend (#676) by anchapin · Pull Request #732 · anchapin/ModPorter-AI

anchapin · 2026-03-07T17:50:13Z

Closes #676

sourcery-ai

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copilot

Pull request overview

Adds a frontend analytics tracking layer and updates lint/type-check tooling across the repo (ESLint for frontend; Ruff/Mypy/Mutmut for Python packages).

Changes:

Introduce a new frontend analytics service plus React hooks for event tracking.
Extend the frontend ESLint flat config with React-related plugins/rules and add related dev dependencies (plus Stryker).
Adjust Python lint/type-check configuration in backend and ai-engine (Ruff rule sets, Mypy strictness, Mutmut config).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
frontend/src/services/analytics.ts	New analytics service API for posting tracking events and generating anon IDs.
frontend/src/hooks/useAnalytics.ts	New hooks wrapping analytics service (page tracking, conversion/upload/export helpers).
frontend/package.json	Adds React ESLint plugins and Stryker mutation-testing deps.
frontend/eslint.config.js	Enables React/React Compiler linting integration in flat ESLint config.
backend/pyproject.toml	Updates Mypy strictness/options, extends Ruff rules/ignores, adds Mutmut config.
ai-engine/pyproject.toml	Extends Ruff rules/ignores, adds Mutmut config, and loosens Mypy strictness/options.

Copilot · 2026-03-07T17:55:35Z

frontend/src/services/analytics.ts

+export const trackPageView = (
+  page: string,
+  options: Omit<AnalyticsOptions, 'properties'> = {}
+): void => {
+  trackEvent(AnalyticsEventType.PAGE_VIEW, AnalyticsEventCategory.NAVIGATION, {
+    ...options,
+    properties: {
+      ...options.properties,
+      page,
+    },
+  });
+};


options is typed as Omit<AnalyticsOptions, 'properties'>, but trackPageView reads options.properties (line 148). This is a type error and will fail TypeScript compilation. Fix by either (a) accepting AnalyticsOptions here, or (b) changing the signature to accept a separate properties?: Record<string, unknown> parameter (or a type that includes properties).

Copilot · 2026-03-07T17:55:35Z

frontend/src/services/analytics.ts

+const getUserId = (): string | undefined => {
+  // For now, we'll use a generated anonymous ID
+  // In the future, this could be tied to actual user accounts
+  let userId = localStorage.getItem('analytics_user_id');
+  if (!userId) {
+    userId = `anon_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
+    localStorage.setItem('analytics_user_id', userId);
+  }
+  return userId;
+};


getUserIdValue() is declared to return string, but it returns getUserId() which is typed as string | undefined. This will fail TypeScript compilation. Since getUserId() always returns a string (it creates one when missing), update getUserId's return type to string (and keep getUserIdValue as string), or otherwise make the return types consistent.

Copilot · 2026-03-07T17:55:35Z

frontend/src/services/analytics.ts

+ * Get or create an anonymous user ID.
+ */
+export const getUserIdValue = (): string => {
+  return getUserId();


getUserIdValue() is declared to return string, but it returns getUserId() which is typed as string | undefined. This will fail TypeScript compilation. Since getUserId() always returns a string (it creates one when missing), update getUserId's return type to string (and keep getUserIdValue as string), or otherwise make the return types consistent.

Suggested change

return getUserId();

return getUserId() ?? '';

Copilot · 2026-03-07T17:55:35Z

frontend/eslint.config.js

+      // React 19 strict rules
+      // React Compiler (formerly React Forget) rules
+      'react-compiler/react-compiler': 'warn',
+      // Warn about deprecated React APIs
+      'react-hooks/set-state-in-effect': 'off', // Allow setState in effects for data fetching patterns
+      // New React 19 rules would go here when eslint-plugin-react releases them


eslint-plugin-react-hooks (added as react-hooks) does not define a set-state-in-effect rule in the commonly used rule set (and with the declared dependency eslint-plugin-react-hooks: ^7.0.1). ESLint will error on unknown rules. Remove this rule entry or replace it with a valid rule name from the installed plugin.

Copilot · 2026-03-07T17:55:35Z

frontend/eslint.config.js

+    },
+    settings: {
+      react: {
+        version: '19.2',


Hardcoding the React version in ESLint settings can drift from the actual installed React version and cause incorrect lint behavior. Prefer version: 'detect' (or omit the setting) so the plugin can infer the correct version from dependencies.

Suggested change

version: '19.2',

version: 'detect',

Copilot · 2026-03-07T17:55:36Z

backend/pyproject.toml

 show_error_codes = true
 namespace_packages = true
 explicit_package_bases = true
+exclude = ["tests/", "scripts/", ".venv/", "docs/", "examples/", "__pycache__/", "__main__.py"]


Mypy’s exclude setting is typically a single regex pattern; providing an array may not be parsed as intended depending on the mypy version/config loader. Consider converting this to a single regex (e.g., using (...)|(...)), or verify that the chosen mypy version supports TOML arrays here.

Suggested change

exclude = ["tests/", "scripts/", ".venv/", "docs/", "examples/", "__pycache__/", "__main__.py"]

exclude = '(^tests/|^scripts/|^\.venv/|^docs/|^examples/|^__pycache__/|__main__\.py$)'

- Add ruff configuration to pyproject.toml for backend/ai-engine linting - Enable rules for common errors (E, F), imports (I), style (Q), naming (N), docstrings (D), and pyupgrade (UP) - Add pydocstyle (D) and pyupgrade (UP) ignore rules for legacy code - Exclude mutants/ directory from backend checks

- Add .eslintrc.json or eslint.config.js (using flat config) - Enable TypeScript ESLint parser - Configure strict rules for React 19 - Add React global for JSX support - Add React Compiler (formerly React Forget) rules - Add eslint-plugin-react and eslint-plugin-react-compiler - Update package.json with new dependencies - Add analytics service files

- Fixed unused 'event' parameter in useAnalytics.ts (changed to _event) - Added eslint-plugin-react and react-compiler to eslint.config.js - Added no-redeclare disable rule for analytics.ts - Restored per-file-ignores for performance.py, rate_limiter.py, task_worker.py - Applied Prettier formatting to ConversionFlowManager.tsx and analytics.ts Co-authored-by: openhands <openhands@all-hands.dev>

Copilot AI review requested due to automatic review settings March 7, 2026 17:50

sourcery-ai bot reviewed Mar 7, 2026

View reviewed changes

Copilot started reviewing on behalf of anchapin March 7, 2026 17:54 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

openhands-agent added 3 commits March 7, 2026 13:41

anchapin force-pushed the feature/eslint-frontend-676 branch from 74bd5a6 to 12a103e Compare March 7, 2026 18:54

fix: resolve formatting issues

a89a926

anchapin merged commit 7f1ea5d into main Mar 7, 2026
8 of 9 checks passed

anchapin deleted the feature/eslint-frontend-676 branch March 7, 2026 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add ESLint configuration for frontend (#676)#732

feat: add ESLint configuration for frontend (#676)#732
anchapin merged 4 commits intomainfrom
feature/eslint-frontend-676

anchapin commented Mar 7, 2026

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	exclude = ["tests/", "scripts/", ".venv/", "docs/", "examples/", "__pycache__/", "__main__.py"]
	exclude = '(^tests/\|^scripts/\|^\.venv/\|^docs/\|^examples/\|^__pycache__/\|__main__\.py$)'

Conversation

anchapin commented Mar 7, 2026

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants