-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add CODEOWNERS file for code review requirements (Issue #700) #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0ebb8d3
1593579
c6cdc1a
acd0160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,69 @@ | ||||
| # Code Ownership Rules | ||||
| # | ||||
| # This CODEOWNERS file defines code ownership and review requirements for the ModPorter-AI project. | ||||
| # Review is required from code owners before merging changes. | ||||
| # | ||||
| # For more information about CODEOWNERS, see: | ||||
| # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | ||||
|
|
||||
| # ============================================================================ | ||||
| # Default Owners (catch-all for any file not matching specific rules) | ||||
| # ============================================================================ | ||||
| * @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # Frontend Team - React/TypeScript UI Components | ||||
| # ============================================================================ | ||||
| # All frontend-related files require review from frontend maintainers | ||||
| /frontend/ @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # Backend Team - Python API and Server | ||||
| # ============================================================================ | ||||
| # All backend-related files require review from backend maintainers | ||||
| /backend/ @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # AI-Engine Team - ML/AI Components | ||||
| # ============================================================================ | ||||
| # All AI engine-related files require review from AI engine maintainers | ||||
| /ai-engine/ @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # Infrastructure & DevOps | ||||
| # ============================================================================ | ||||
| # Docker and infrastructure configurations | ||||
| /docker/ @alex | ||||
| docker-compose*.yml @alex | ||||
| Dockerfile* @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # Security & Compliance | ||||
| # ============================================================================ | ||||
| # Security-related files require review from security team | ||||
| /.github/security-check.sh @alex | ||||
| /.github/security-config-guide.md @alex | ||||
|
|
||||
| # ============================================================================ | ||||
| # Documentation | ||||
| # ============================================================================ | ||||
| # Documentation changes can be reviewed by any maintainer | ||||
| /docs/ @alex | ||||
| *.md @alex | ||||
| !/.github/*.md | ||||
|
||||
| !/.github/*.md |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS uses “last matching pattern wins”. Because /.github/ appears after the more specific /.github/security-*.{sh,md} entries, it will override those specific rules if different owners are ever assigned. To keep the file future-proof and ensure specific rules can override general ones, move the broad /.github/ rule above any more specific .github/* rules (or move the specific rules below it).
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,4 +48,5 @@ pydantic-settings | |
|
|
||
| # Monitoring | ||
| prometheus-client | ||
| psutil | ||
| psutil | ||
| structlog>=24.0.0 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header comment implies CODEOWNERS itself “requires” review before merging, but CODEOWNERS only defines owners; enforcement requires a branch protection rule configured to “Require review from Code Owners”. Consider rewording this comment to avoid implying the repository setting is being enforced by this file alone.