Add Bikes #43
Open
Add Bikes #43
+2,938
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andipaetzold
requested changes
Mar 17, 2023
| make: string; | ||
| name: string; | ||
| year?: number; | ||
| level: number; // negative for special cases like Tron bike |
There was a problem hiding this comment.
Can we make the level optional instead of storing negative values?
| @@ -234,6 +234,19 @@ export interface Segment { | |||
|
|
|||
| export type SegmentType = "sprint" | "climb" | "segment"; | |||
|
|
|||
| export interface Bike { | |||
There was a problem hiding this comment.
Do bikes have some kind of id we can use to identify them?
| year?: number; | ||
| level: number; // negative for special cases like Tron bike | ||
| frameWeight: number; | ||
| frameCdA: number; |
There was a problem hiding this comment.
Some frames have 0 or a negative number as CdA. Not an aero expert, but this looks more like the difference of the current frame compared to a "default bike". Maybe we can be more explicit in the name about this. A negative bike would probably ride itself :D
| name: string; | ||
| year?: number; | ||
| level: number; // negative for special cases like Tron bike | ||
| frameWeight: number; |
There was a problem hiding this comment.
Let's add a jsdoc comment about the unit of the weights. It's obvious from the numbers but with the types it could be kg or gramms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, this PR is not adding Zwift source files.
I wanted to avoid polluting dependencies and the main codebase with ugly XML parsing & processing, so I've put everything that handles it into the
scripts/extract-data-from-app-sourcefolderRunning
scripts/extract-data-from-app-source/index.mjswill generatedata/bikes.json.data/bikes.jsonwill then be processed byupdate-dataas the other existing data (routes, segments, worlds), type-checked, and outputted to thesrcfolder for publishing.I'm not used to coding without ESLint so the formatting might not be consistent, feel free to share your config and I'll reformat it.
I'll DM you a quick video walk-through with some background info :)