Avoid selecting submitter password on library detail - #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the public library detail query from loading the submitter password hash when the page only needs the username. This removes the unnecessary sensitive-column selection reported by Sentry while preserving the existing single-query rendering behavior.
Context
The detail queryset used
select_related("created_by"), which materialized every column from the related user row. The template only renderedcreated_by.username, so fields such as the password hash were fetched without being used.Changes
What changed
users_user.password.Scope notes
Notes / constraints
Verification
Testing
nox -s testsnpm run build:cssnox -s e2egit diff --check