Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

Enable a not code based url for nora-service#41

Open
mabels wants to merge 1 commit into
andrei-tatar:masterfrom
mabels:master
Open

Enable a not code based url for nora-service#41
mabels wants to merge 1 commit into
andrei-tatar:masterfrom
mabels:master

Conversation

@mabels

@mabels mabels commented Jan 20, 2020

Copy link
Copy Markdown

added the functionality to get the service url from the token

@mabels mabels changed the title Enable a not codebased url for nora-service Enable a not code based url for nora-service Jan 20, 2020
@Xumpy

Xumpy commented Jan 22, 2021

Copy link
Copy Markdown

Due to the recent problems with bandwith I have installed my own server on heroku.
I have noticed 2 problems.

  • There is a validation that failes in the server where the invalid request_url in oauth.ts is triggerd.
  • Nora.ts has to be updated due to the hardcoded url

My solution was to remove that oauth.ts validation. I have a commit for this in my forked repo.
I think that people would be very interested in hosting their own nora-server.

Changes on the server side are not that imprtant for me but due to my own changes in Nora.ts under the nodered module I'm not able to update the connector anymore.
Can you tell me if or when this hardcoded url will be removed?Thanks for the hard work Andrei!

@andrei-tatar

andrei-tatar commented Feb 2, 2021

Copy link
Copy Markdown
Owner

@Xumpy if you mean on this line: https://github.com/andrei-tatar/nora-service/blob/875f7a81b5f3eb804c4ebf7f58b348863cb05b26/src/http/controllers/oauth.ts#L55
It's based on the firebase project id. It should always be in that format.

I'm waiting on google's approval on the new firebase based service. I don't plan on doing any further development work on the previous version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants