Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

Two-factor authentication#58

Open
jvondrus wants to merge 7 commits into
andrei-tatar:masterfrom
jvondrus:master
Open

Two-factor authentication#58
jvondrus wants to merge 7 commits into
andrei-tatar:masterfrom
jvondrus:master

Conversation

@jvondrus

Copy link
Copy Markdown

Allow enable Two-factor authentication on the lock and garage devices if they are controlled by Google Assistant (it's not authentication for inputs by Node-RED). It's not required any change on server service.
Supported authentication:

  • basic acknowledgement (yes or no)
  • pin code (only numbers)

@jvondrus

Copy link
Copy Markdown
Author

One improvement / fix at ...ts files:

pin: ( config.twoFactor && config.twoFactorMode === 'pin') ? (Math.floor(config.twoFactorPin)+'') : undefined,

@andrei-tatar

Copy link
Copy Markdown
Owner

Thanks for the contribution. The reason I didn't endup adding it in the node-red plugin (even though it is already supported by the service) is that I wanted it to be more generic, not specific to any kind of node.

I was actually thinking of adding it as part as the group config, so each node that's in a group, will use the specified 2FA method. So if you want devices with 2FA, you just create a new nora-config with the same token, different group name and setup 2FA options in that node, so all the nodes that will be using this config, will also use 2FA.

@jvondrus

Copy link
Copy Markdown
Author

2FA method with groups is really good idea, better than settings it on each device.

@cookemmm

cookemmm commented Jun 7, 2020

Copy link
Copy Markdown

any update on this being implemented?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants