This repository was archived by the owner on Apr 20, 2021. It is now read-only.
First draft of sensors code#73
Open
readeral wants to merge 1 commit into
Open
Conversation
|
Nice, i see you started with the changes for node-red-contrib-nora. Are planning also to do the backend PR? |
|
I implemented the Open Close sensor also, I'll finish my vacuum pr and take a look at this if i can merge mine or drop it and use this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is obviously far from working - and largely is just an attempt at building up the models, so with some comments from @andrei-tatar I'll probably be able to start working this toward a proper implementation