Adds support for test mocks#8
Open
IdahoEv wants to merge 15 commits into
Open
Conversation
Feature/add mocks
Author
|
@andrewmunsell checking in ... are you maintaining this project? I can fork and maintain, but don't want to take it from you if you're planning to maintain it. |
|
@IdahoEv what was the verdict on this? |
Author
|
@Bored0ne I don't think I ever heard back, I worked with my own fork. I wasn't on that job for very long though, so it's well in my past, now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the same facility requested in #6 : the ability to mock some dependencies in test. This pull request implements such a feature, with documentation and tests.
I intentionally didn't include the new code in the main exports of index.js, it needs a separate import by the end user. The reason is that I like how small needlepoint is (my company builds widgets, not SPAs), so I didn't want the mocking code to be included in production builds.
Please let me know if you'd like this pull request, and if you're still maintaining the project. Thanks!