Implement Python 3 support, tested in both 2.7 and 3.5. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged |
| if not silent: | ||
| raise ImportStringError(import_name, e), None, sys.exc_info()[2] | ||
| if sys.version_info.major == 2: | ||
| exec("raise ImportStringError(import_name, e), None, sys.exc_info()[2]") # Get around SyntaxError in Py3 |
There was a problem hiding this comment.
Came here to submit exactly the same patch. Minor note here -- you could replace this whole if/else block with
six.reraise(ImportStringError, ImportStringError(import_name, e), sys.exc_info()[2])
assuming you've imported six and added it to the dependencies in setup.py
Author
|
At this point it looks like this project has been completely abandoned. Due to that, I wrote my own library (YACT) to address my concerns. I hate to publicize on another libs project, but there it is. https://github.com/dreadpirate15/yact Unittests run against 2.7 and currently released versions of Python3. It's available on PyPi, I'm currently working on a couple small features and making documentation actually useful (sorry folks), but I consider the current API stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested my changes using the tests.py module and using it in my own Python3 code, this maintains backwards compatibility while also being Python 3 compatible. Read to merge.