Parse ReplayGain data from LAME Xing/Info header #2840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icbaker
requested changes
Nov 5, 2025
| * | ||
| * <p>b010 = audiophile | ||
| */ | ||
| public final byte field1Name; |
There was a problem hiding this comment.
We don't need to perfectly match the spec here - it might be a clearer API to have an IntDef that reflects the three possible values of unset, radio & audiophile.
Similarly, maybe a nested type structure would be clearer than name1A, name1B, name2A etc.
Something like:
public final class Mp3InfoReplayGain {
public static final class GainField {
public final @Name int name;
public final @Originator int originator;
public final int gain;
}
public final float peak;
public final GainField field1;
public final GainField field2;
}| public final long dataSize; | ||
|
|
||
| /** Whether this frame is the LAME variant of a Xing frame, and hence has ReplayGain data. */ | ||
| public final boolean hasReplayGain; |
There was a problem hiding this comment.
Similar comment here, instead of a boolean controlling the presence of all the other fields, move them into a type that can then be nullable.
Maybe you can even re-use the Metadata.Entry subclass here? Instead of duplicating all the fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://gabriel.mp3-tech.org/mp3infotag.html#replaygain