-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed memory leaks and added drawPageAsPNGRaw method #58
Open
anthrax63
wants to merge
15
commits into
andytango:master
Choose a base branch
from
anthrax63:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2023
Thanks @anthrax63 - I will review these changes and merge next week |
@andytango Do you have any plans to merge in the near future? I am currently facing this issue as well? @anthrax63 when I use the package you published, I find that there are still memory leaks present import { createMuPdfWithoutContext } from "@cahva/mupdf-js";
//const save2imgs =require("./libs/save2img.js");
(async () => {
for (let i = 0; i < 5; i++) {
const mupdf = await createMuPdfWithoutContext();
const ctx = mupdf.createContext();
const doc = mupdf.load(ctx, buf);
console.log(mupdf.drawPageAsPNG(ctx, doc, 1, 300).length);
mupdf.freeDocument(doc);
mupdf.freeContext(ctx);
}
})();
setInterval(() => {
// mock something
}, 50000); ![]()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my application, I have seen that the consumed process memory grows over time. As a result of research, I found that some methods allocate memory in C code that is never freed. This pull request solves this problem. Also method drawPageAsPNGRaw has been added, which immediately returns binary data. Also was fixed small issue - all methods returning strings had null byte at the end. Now this byte is truncated.