ci test bugfix - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the lowering logic for per-field variable shifts in the
lowerShiftfunction, updating both the implementation and the corresponding test cases. The main change is to use a more accurate shift-amount model that matches the scalar LLVM reference, especially for out-of-range shift amounts. The code now handles per-field shift amounts without masking, correctly clears fields when over-shifting, and updates the logic for selecting and blending shifted values. Test checks are updated to match the new IR structure and variable names.Lowering logic improvements:
i1types is preserved, always returning the input for any shift amount.Test updates:
shl_i2.ll,shl_i4.ll,lshr_i2.ll, andlshr_i4.llare updated to match the new variable names and logic, verifying the new%shift.hasstep,%shift.sel,%shift.raw,%shift.confined, and%shift.blendsequence. [1] [2] [3] [4]