chore: replace jest with vitest #223
Conversation
|
Great! Why did you go with the analog version and didn’t use the native Vitest support that comes with Nx out of the box? Was there a particular reason, e.g. something didn't work? |
This makes `rxMutation` a fully autonomous function which can also be used entirely independently of the SignalStore. It also exposes the following additional properties: - `isSuccess` - `hasValue` - `value`
|
@rainerhahnekamp Recency bias. I have been focused on Analog Vitest Plugin and trying to solve some issues I am having with it. I might close this PR and open another. I really lost no time making this PR as I uncovered some issues along the way. |
|
Using |
|
By not using |
rainerhahnekamp
force-pushed
the
main
branch
from
463ecfc to
efb3481
Compare
|
Hey @jdegand 👋, has been a while. It would be great if demo-app would at least support Vitest as well. Were you able to make some progress with your other branch? |
|
@rainerhahnekamp I merged the branch. Adding the Vitest setup to demo-app might cause a check to fail, as I think Vitest returns a failure when there are no tests. |
I used
npx nx g @analogjs/platform:setup-vitest --project demoandnpx nx g @analogjs/platform:setup-vitest --project ngrx-toolkitto automatically convert them.I had to use
no-verifysincedemohas no unit tests. This causes a failure. I did lint and added peer-dependencies to the onepackage.json. I had TypeScript issues with the onevite.config.mts.I removed all references to Jest and removed the VSCode extension as well.
I guess you could want to use vitest and playwright together for the demo app. It wasn't really specified, but I figured I might as well give you something to look at first.
There are also peer dependency issues with
docusaurusand@types/node.