Skip to content

chore: replace jest with vitest #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore: replace jest with vitest #223

wants to merge 12 commits into from

Conversation

@jdegand
Copy link

@jdegand jdegand commented Sep 1, 2025 •
edited
Loading

I used npx nx g @analogjs/platform:setup-vitest --project demo and npx nx g @analogjs/platform:setup-vitest --project ngrx-toolkit to automatically convert them.

I had to use no-verify since demo has no unit tests. This causes a failure. I did lint and added peer-dependencies to the one package.json. I had TypeScript issues with the one vite.config.mts.

I removed all references to Jest and removed the VSCode extension as well.

I guess you could want to use vitest and playwright together for the demo app. It wasn't really specified, but I figured I might as well give you something to look at first.

There are also peer dependency issues with docusaurus and @types/node.

@rainerhahnekamp
Copy link
Collaborator

rainerhahnekamp commented Sep 1, 2025 •
edited
Loading

Great! Why did you go with the analog version and didn’t use the native Vitest support that comes with Nx out of the box?

Was there a particular reason, e.g. something didn't work?

@manfredsteyer
feat: Make rxMutation standalone (angular-architects#219)
5bb5dd8 
This makes `rxMutation` a fully autonomous function
which can also be used entirely independently of the
SignalStore.

It also exposes the following additional properties:
- `isSuccess`
- `hasValue`
- `value`
@jdegand
Copy link
Author

jdegand commented Sep 1, 2025 •
edited
Loading

@rainerhahnekamp Recency bias. I have been focused on Analog Vitest Plugin and trying to solve some issues I am having with it. I might close this PR and open another. I really lost no time making this PR as I uncovered some issues along the way.

@jdegand
Copy link
Author

jdegand commented Sep 1, 2025 •
edited
Loading

Using @nx/vite should help with inferred migration. Running npx nx g convert-to-inferred should help convert everything with no issues and then you could remove the .env file.

@jdegand
Copy link
Author

jdegand commented Sep 2, 2025 •
edited
Loading

By not using nx/vite generator, this PR has issues with config files that require manual updates. I am working on a new branch (nx-vitest). I had a few failing tests that I fixed by changing the target to es2016 versus es2022. All tests work in ngrx-toolkit. Do you want me to generate setup in demo-app although there are no unit tests?

@rainerhahnekamp
Copy link
Collaborator

Hey @jdegand 👋, has been a while. It would be great if demo-app would at least support Vitest as well. Were you able to make some progress with your other branch?

@jdegand
Copy link
Author

jdegand commented Sep 29, 2025 •
edited
Loading

@rainerhahnekamp I merged the branch. Adding the Vitest setup to demo-app might cause a check to fail, as I think Vitest returns a failure when there are no tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdegand @rainerhahnekamp @manfredsteyer