Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Bootstrap4 template choices.tpl.html #2074

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

huggler
Copy link

@huggler huggler commented Nov 3, 2017

Change ng-show="$select.open && $select.items.length > 0"
for this ng-class="{show : $select.open && $select.items.length > 0}"

@Jefiozie Jefiozie self-requested a review February 5, 2018 20:25
Copy link
Contributor

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up dist folder before review

@huizhoujava
Copy link

huizhoujava commented Jul 2, 2018

Can someone help review and merge the pull request?

By the way, I tried the built select.js and select.css from https://github.com/bmontgomery/ui-select/tree/master/dist with Bootstrap 4.1.1 and AngularJS 1.7.2, but the select widget is not working.

If I add attribute theme="bootstrap4" on ui-select element, it is rendered like this
ui-select-bootstrap4

If I add attribute theme="bootstrap" on ui-select element, it is rendered like this
ui-select-bootstrap4-bootstrap

For both theme, when I click the input box , the choices are not displayed.

If I change to use Bootstrap 3.3.7 with attribute theme="bootstrap" on ui-select element, the select widget is working as expected.

Here is the code I use for testing ui-select-test.zip

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants