This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix: appendToBody doesn't work with jQuery < 1.10.0, fix for #944 #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexFess
changed the title
AlexFess
changed the title
|
Add a fix for #944 (remove target element check) |
|
This needs squashing, then rebasing. |
.relpaceWith in jQuery (version less then 1.10) doesn't work properly and as so, ui-select with 'appendToBody=true' doesn't display selected value. Use .after() and .remove() instead of .replaceWith() to avoid this issue. fix for angular-ui#944: Don't restore focus if it was moved out of select (irregardles of target element). Otherwise it looks too confusing when clicking on links or any other control that is not an input/button/textarea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.relpaceWith in jQuery (version less then 1.10) doesn't work properly
and as so, ui-select with 'appendToBody=true' doesn't display selected
value.
Use .after() and .remove() instead of .replaceWith() to avoid this
issue.