Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): ensure full rebuild after initial error build in watch mode #29568

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Feb 4, 2025

If an initial build of an application results in an error during watch mode (including ng serve), the following non-error rebuild will now always be a full build result. This ensures that all new files are available for later incremental build result updates.

Closes #29566

@clydin clydin added the target: patch This PR is targeted for the next patch release label Feb 4, 2025
@clydin clydin requested a review from alan-agius4 February 4, 2025 16:06
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 4, 2025
… watch mode

If an initial build of an application results in an error during watch mode
(including `ng serve`), the following non-error rebuild will now always be
a full build result. This ensures that all new files are available for later
incremental build result updates.
@clydin clydin force-pushed the application/initial-incremental-error branch from 971d05d to c104bc6 Compare February 4, 2025 16:46
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 5, 2025
@alan-agius4 alan-agius4 merged commit b24089e into angular:main Feb 5, 2025
31 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng serve: Builder must provide an initial full build before incremental results
2 participants