Skip to content

Preparing v20 release #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17,235 changes: 9,083 additions & 8,152 deletions package-lock.json

Large diffs are not rendered by default.

48 changes: 24 additions & 24 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@angular/fire",
"version": "19.2.0",
"version": "20.0.0",
"description": "Angular + Firebase = ❤️",
"private": true,
"scripts": {
Expand Down Expand Up @@ -46,16 +46,16 @@
},
"homepage": "https://github.com/angular/angularfire#readme",
"dependencies": {
"@angular-devkit/architect": "~0.1900.0",
"@angular-devkit/core": "^19.0.0",
"@angular-devkit/schematics": "^19.0.0",
"@angular/common": "^19.0.0",
"@angular/compiler": "^19.0.0",
"@angular/core": "^19.0.0",
"@angular/platform-browser": "^19.0.0",
"@angular/platform-browser-dynamic": "^19.0.0",
"@angular/router": "^19.0.0",
"@schematics/angular": "^19.0.0",
"@angular-devkit/architect": "~0.2000.0",
"@angular-devkit/core": "^20.0.0",
"@angular-devkit/schematics": "^20.0.0",
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/platform-browser-dynamic": "^20.0.0",
"@angular/router": "^20.0.0",
"@schematics/angular": "^20.0.0",
"esbuild": "^0.24.0",
"firebase": "^11.8.0",
"firebase-functions": "^6.1.0",
Expand All @@ -75,13 +75,13 @@
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.0.0",
"@angular-eslint/builder": "^19.0.0",
"@angular-eslint/eslint-plugin": "^19.0.0",
"@angular/animations": "^19.0.0",
"@angular/cli": "^19.0.0",
"@angular/compiler-cli": "^19.0.0",
"@angular/platform-server": "^19.0.0",
"@angular-devkit/build-angular": "^20.0.0",
"@angular-eslint/builder": "20.0.0-alpha.1",
"@angular-eslint/eslint-plugin": "20.0.0-alpha.1",
"@angular/animations": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/platform-server": "^20.0.0",
"@types/fs-extra": "^7.0.0",
"@types/gzip-size": "^5.1.1",
"@types/inquirer": "^0.0.44",
Expand All @@ -92,12 +92,12 @@
"@types/semver": "^7.1.0",
"@types/triple-beam": "^1.3.0",
"@types/winston": "^2.4.4",
"@typescript-eslint/eslint-plugin": "^7.11.0",
"@typescript-eslint/parser": "^7.11.0",
"@typescript-eslint/eslint-plugin": "^8.33.0",
"@typescript-eslint/parser": "^8.33.0",
"conventional-changelog-cli": "^1.2.0",
"cross-spawn": "^7.0.3",
"eslint": "^8.54.0",
"eslint-plugin-import": "^2.28.1",
"eslint": "^9.27.0",
"eslint-plugin-import": "^2.31.0",
"globals": "^13.21.0",
"globalthis": "^1.0.1",
"jasmine": "^5.0.0",
Expand All @@ -109,15 +109,15 @@
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "^2.1.0",
"karma-safarinative-launcher": "^1.1.0",
"ng-packagr": "^19.0.0",
"ng-packagr": "^20.0.0",
"reflect-metadata": "^0.1.2",
"replace-in-file": "^5.0.2",
"rimraf": "^2.5.4",
"shelljs": "^0.8.0",
"ts-patch": "^3.2.1",
"ts-transformer-keys": "^0.4.4",
"tslint": "~6.1.0",
"typescript": ">=5.5 <5.7",
"typescript": ">=5.8 <5.9",
"yaml": "^2.7.0"
},
"typings": "index.d.ts"
Expand Down
29 changes: 0 additions & 29 deletions src/compat/angularfire2.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,38 +90,9 @@ describe('angularfire', () => {
});

if (typeof window !== 'undefined') {

it('should have the provided name', () => {
expect(app.name).toBe(appName);
});

it('should use an already intialized firebase app if it exists', done => {
@NgModule({
imports: [
AngularFireModule.initializeApp(COMMON_CONFIG, appName),
BrowserModule
]
})
class MyModule implements DoBootstrap {
// eslint-disable-next-line @angular-eslint/no-empty-lifecycle-method,@typescript-eslint/no-empty-function
ngDoBootstrap() {
}
}

const compilerFactory: CompilerFactory =
defaultPlatform.injector.get(CompilerFactory, null);
const moduleFactory = compilerFactory.createCompiler().compileModuleSync(MyModule);

defaultPlatform.bootstrapModuleFactory(moduleFactory)
.then(moduleRef => {
const ref = moduleRef.injector.get(FirebaseApp);
expect(ref.name).toEqual(app.name);
}).then(done, e => {
fail(e);
done();
});
});

}
});
});
2 changes: 1 addition & 1 deletion src/compat/messaging/messaging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class AngularFireMessaging {
})
);

const notificationPermission$ = new Observable<string>(emitter => {
const notificationPermission$ = new Observable<void>(emitter => {
navigator.permissions.query({ name: 'notifications' }).then(notificationPerm => {
notificationPerm.onchange = () => emitter.next();
});
Expand Down
16 changes: 8 additions & 8 deletions src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
"author": "angular,firebase",
"license": "MIT",
"peerDependencies": {
"@angular/common": "^19.0.0",
"@angular/core": "^19.0.0",
"@angular/platform-browser": "^19.0.0",
"@angular/platform-browser-dynamic": "^19.0.0",
"@angular/platform-server": "^19.0.0",
"@angular/common": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/platform-browser-dynamic": "^20.0.0",
"@angular/platform-server": "^20.0.0",
"rxjs": "~7.8.0",
"firebase-tools": "^13.0.0"
"firebase-tools": "^14.0.0"
},
"peerDependenciesMeta": {
"firebase-tools": { "optional": true },
Expand All @@ -38,8 +38,8 @@
"dependencies": {
"firebase": "^11.8.0",
"rxfire": "^6.1.0",
"@angular-devkit/schematics": "^19.0.0",
"@schematics/angular": "^19.0.0",
"@angular-devkit/schematics": "^20.0.0",
"@schematics/angular": "^20.0.0",
"tslib": "^2.3.0"
},
"ng-update": {
Expand Down
2 changes: 1 addition & 1 deletion src/schematics/deploy/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ or the new Firebase App Hosting product https://firebase.google.com/docs/app-hos
open(plainText.split(': ')[1]);
}
}
return [info.message, ...(info[tripleBeam.SPLAT as any] || [])]
return [info.message, ...(info[tripleBeam.SPLAT as any] || []) as any]
.filter((chunk) => typeof chunk === 'string')
.join(' ');
})
Expand Down
2 changes: 1 addition & 1 deletion src/schematics/firebaseTools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const getFirebaseTools = () => globalThis.firebaseTools ?
globalThis.firebaseTools = firebaseTools;
const version = firebaseTools.cli.version();
console.log(`Using firebase-tools version ${version}`);
if (semverCompare(version, '13.0.0') === -1) {
if (semverCompare(version, '14.0.0') === -1) {
console.error('firebase-tools version 13.0.0+ is required, please upgrade and run again');
return Promise.reject();
}
Expand Down
12 changes: 7 additions & 5 deletions src/zones.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,15 @@ export const ɵzoneWrap = <T= unknown>(it: T, blockUntilFirst: boolean, logLevel
} else if (ret instanceof Promise) {
// eslint-disable-next-line @typescript-eslint/no-misused-promises
return run(
() =>
new Promise((resolve, reject) => {
pendingTasks.run(() => ret).then(
() => {
pendingTasks.run(() => ret);
return new Promise((resolve, reject) => {
ret.then(
(it) => runInInjectionContext(injector, () => run(() => resolve(it))),
(reason) => runInInjectionContext(injector, () => run(() => reject(reason)))
);
}));
)
});
});
} else if (typeof ret === 'function' && taskDone) {
// Handle unsubscribe
// function() is needed for the arguments object
Expand Down