Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the ability to copy module import to the clipboard #19200

Closed
wants to merge 3 commits into from
Closed

feat: add the ability to copy module import to the clipboard #19200

wants to merge 3 commits into from

Conversation

hadzhiyski
Copy link

@hadzhiyski hadzhiyski commented Apr 28, 2020 •
edited
Loading

@hadzhiyski hadzhiyski requested a review from a team as a code owner April 28, 2020 20:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2020
@josephperrott josephperrott requested review from devversion and removed request for a team April 28, 2020 20:49
@hadzhiyski hadzhiyski mentioned this pull request Apr 28, 2020
Open
@hadzhiyski hadzhiyski changed the title Docs copy import feat: add the ability to copy module import to the clipboard Apr 28, 2020
Splaktar
Splaktar approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the P4 A relatively minor issue that is not relevant to core functions label Apr 30, 2020
devversion
devversion previously approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should wait though until the material.angular.io PR is ready for merge.

@devversion devversion added lgtm target: patch This PR is targeted for the next patch release labels Apr 30, 2020
hadzhiyski added a commit to hadzhiyski/material.angular.io that referenced this pull request May 4, 2020
@hadzhiyski
chore: add curly braces around export name.
6aac911 
Reason for change: angular/components#19200 (comment)
@hadzhiyski hadzhiyski requested a review from crisbeto May 4, 2020 10:19
crisbeto
crisbeto previously approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hadzhiyski added a commit to hadzhiyski/material.angular.io that referenced this pull request May 7, 2020
@hadzhiyski
chore: add curly braces around export name.
213876c 
Reason for change: angular/components#19200 (comment)
hadzhiyski added a commit to hadzhiyski/material.angular.io that referenced this pull request Jun 15, 2020
@hadzhiyski
chore: add curly braces around export name.
6ea712d 
Reason for change: angular/components#19200 (comment)
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
Splaktar
Splaktar previously approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the mat-aio PR is ready to go now.

@Splaktar
Copy link
Member

@hadzhiyski if you get a chance, can you please rebase this so that the CI will pass?

@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label May 14, 2021
hadzhiyski added a commit to hadzhiyski/material.angular.io that referenced this pull request May 16, 2021
@hadzhiyski
chore: add curly braces around export name.
061f60a 
Reason for change: angular/components#19200 (comment)
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 28, 2021
@andrewseguin andrewseguin removed the P4 A relatively minor issue that is not relevant to core functions label Mar 28, 2022
@andrewseguin andrewseguin dismissed stale reviews from crisbeto and devversion via 294137e May 2, 2022 20:32
@andrewseguin
Copy link
Contributor

This PR is being closed due to inactivity and needing rebase. Please feel free to re-open the change after rebasing and we can take another look at getting it merged.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@crisbeto crisbeto crisbeto left review comments

@Splaktar Splaktar Splaktar left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hadzhiyski @Splaktar @andrewseguin @crisbeto @devversion @googlebot @mmalerba