Skip to content

feat(cdk-experimental/ui-patterns): add label control #31459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ok7sai
Copy link
Contributor

@ok7sai ok7sai commented Jun 27, 2025

No description provided.

@ok7sai ok7sai requested a review from wagnermaciel June 27, 2025 22:20
@ok7sai ok7sai requested a review from a team as a code owner June 27, 2025 22:20
@ok7sai ok7sai requested review from crisbeto and removed request for a team June 27, 2025 22:20
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 27, 2025
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

labelledBy?: SignalLike<string[]>;

/** Whether the user-provided `aria-labelledby` should be appended to the default. */
labelledByAppend?: SignalLike<boolean>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our conversation, let's remove labelledByAppend, describedBy, and describedByAppend. Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants