feat: show deprecated related information in material/tooltip
#1274
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
naaajii
force-pushed
the
fix/29873
branch
2 times, most recently
from
d2c1e1f
to
33d57e7
Compare
|
(apologies for ping) @crisbeto @devversion can we land this since angular/components#29873 is merged? |
| }) | ||
| export class DeprecatedFieldComponent { | ||
| /** Message regarding the deprecation */ | ||
| @Input() message!: string; |
There was a problem hiding this comment.
Nit: consider using input.required
There was a problem hiding this comment.
i'm not sure how will i set the value for this input dynamically via ComponentPortal if we use signal based input.
There was a problem hiding this comment.
Ohh. It doesn't need to be an input at all then, I think 😄
There was a problem hiding this comment.
yes, true. I missed that! 😄
| // all of the deprecated markers end with `deprecated-marker` | ||
| // in their class name | ||
| const deprecatedElements = | ||
| this._elementRef.nativeElement.querySelectorAll(`[class$=deprecated-marker]`); |
There was a problem hiding this comment.
its shorter for like:
querySelectorAll('.docs-api-deprecated-marker, .docs-api-class-deprecated-marker, .docs-api-class-interface-marker, .some-more')There was a problem hiding this comment.
I see. How about adding a small comment illustrating the pattern + using -deprecated-marker as suffix test?
There was a problem hiding this comment.
should be good now, lemme know if it needs rewording cause my english isn't so good.
previously we weren't showing any other information other than `breaking-change` for deprecated fields, this commit adds a component that protrays information regarding deprecation in tooltips rather than `title` attribute closes angular/components#29839
previously we weren't showing any other information other than
breaking-changefor deprecated fields, this commit adds a component that protrays information regarding deprecation in tooltips rather thantitleattributecloses angular/components#29839