Skip to content

Commit

Permalink
build: avoid use of ts-node wrapper script as it breaks child process…
Browse files Browse the repository at this point in the history
… forking (#1703)

`ts-node` spawns a custom node launcher script and has a brotli-base64
encoded configuration that will point to the user-provided entry-point.

This breaks child process forking as we wouldn't be able to specify our
custom build worker and basically `ng-dev` would run inside `ng-dev`
again.
  • Loading branch information
devversion authored Jun 23, 2022
1 parent 4ff7a30 commit 7e91830
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
],
"main": "./dist/client/extension",
"scripts": {
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"ng-dev": "cross-env TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json TS_NODE_TRANSPILE_ONLY=1 node --no-warnings --loader ts-node/esm node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"compile": "tsc -b server/banner.tsconfig.json && tsc -b && node esbuild.js",
"compile:test": "tsc -b test.tsconfig.json",
"compile:integration": "tsc -b integration && yarn --cwd integration/project build",
Expand Down Expand Up @@ -229,11 +229,12 @@
"@types/node": "14.18.16",
"@types/vscode": "1.67.0",
"clang-format": "1.8.0",
"cross-env": "^7.0.3",
"esbuild": "0.14.39",
"jasmine": "3.99.0",
"prettier": "2.6.2",
"tslint": "6.1.3",
"ts-node": "^10.8.1",
"tslint": "6.1.3",
"tslint-eslint-rules": "5.4.0",
"vsce": "1.100.1",
"vscode-languageserver-protocol": "3.16.0",
Expand Down
9 changes: 8 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3090,7 +3090,14 @@ [email protected]:
postcss "^8.3.7"
pretty-bytes "^5.3.0"

cross-spawn@^7.0.3:
cross-env@^7.0.3:
version "7.0.3"
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
dependencies:
cross-spawn "^7.0.1"

cross-spawn@^7.0.1, cross-spawn@^7.0.3:
version "7.0.3"
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-7.0.3.tgz#f73a85b9d5d41d045551c177e2882d4ac85728a6"
integrity sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==
Expand Down

0 comments on commit 7e91830

Please sign in to comment.